Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep steering on radar fault #442

Merged
merged 1 commit into from Nov 20, 2018
Merged

Keep steering on radar fault #442

merged 1 commit into from Nov 20, 2018

Conversation

vntarasov
Copy link

GM radar is somewhat flaky. Couple people had reported radar faulted on them in the middle of the turn, and since openpilot disengages immediately, it's an unpleasant experience to catch steering wheel that lost LKA torque.
I was asked if it's possible to keep steering when openpilot detects that the radar went out of calibration.

@rbiasini
Copy link
Contributor

We should do the same on all other cars.

@rbiasini rbiasini merged commit e32463e into commaai:devel Nov 20, 2018
adhintz added a commit to adhintz/openpilot that referenced this pull request Dec 18, 2018
* GM: remove refactor leftovers (commaai#440)

* Move calibration values (commaai#441)

* initial commit

* moved constants

* Keep steering on radar fault (commaai#442)

* Add initial support for Holden/Opel Astra BK (commaai#431)

* Added Astra support to README and RELEASE notes (commaai#443)

* Honda Nidec: avoid giraffe setting alert when car is turned off (commaai#449)

* Adding support for 2018 GMC Acadia Denali (commaai#453)

* added acadia

* adding acadia

* adding acadia

* Update radar_interface.py

* adding acadia

* refactored

* fixed tuning

* Adding acadia

* Update interface.py

* fixed whitespace

* fixed whitespace

* ACC cancel button

* GM: Cadillac ATS Coupe 2018 support (commaai#445)

* GM: Cadillac ATS Coupe 2018 support

* Missed adding Cadillac ATS

* Fixed Capitalization + Made CT6 Comment Cleaner (commaai#456)

* Update README.md

* Updated CT6 comment

* Add Lexus RX450HL as sub to RX450H (commaai#458)

Add Lexus RX450HL as sub to RX450H

* on gas pedal press, send cancel ACC button to cancel OpenPilot

* try sending +1 counter so our message isn't a duplicate

* only do the accel pedal for specific cars

* do accel pedal for all models

* try always sending 1 for cancel acc frame

* clean up comments and remove unused moving_fast

* remove unused make can msg parameters

* try incrementing wheel button counter by 2 to see if that works better for cancel

* Squashed 'opendbc/' changes from 3f6cd74..e108b6b

e108b6b Add more Sign recognitions (commaai#126)
6e8a363 Add GM FCW Alert (Take 2) (commaai#125)
368701a Revert "Add GM FCW dashboard alert (commaai#123)" (commaai#124)
98b5f66 Add GM FCW dashboard alert (commaai#123)
71b7588 Adds dbc for 2019 Honda Insight (commaai#122)

git-subtree-dir: opendbc
git-subtree-split: e108b6b

* Squashed 'pyextra/' changes from fb152de..8cc1594

8cc1594 update overpy
2c18997 switch to forked version of overpy

git-subtree-dir: pyextra
git-subtree-split: 8cc1594238fcae6acb8bcd825ac73bbca586b1be

* openpilot v0.5.7 release

* try to simplify message logic

* clean up code

* move Chrylser into main table in readme

* 0.5.7 hotfixes

* On pedal press, if in steer error state, do not send ACC cancel button message.
Sending the ACC cancel button message in this state causes the car to display warnings.

* set the new ret.openpilotLongitudinalControl = False

* hotfix: wait longer in CDP mode before switching to fast charge, so EON can boot (commaai#469)

* generalize jeep fingerprint to also cover 2017 Jeep Grand Cherokee Trailhawk

* disable pedal_gas for now to do a devel release. Sending 23b might fault other cars.

* add jeep grand cherokee 2017 to readme car list
adhintz added a commit to adhintz/openpilot that referenced this pull request Dec 20, 2018
)

* GM: remove refactor leftovers (commaai#440)

* Move calibration values (commaai#441)

* initial commit

* moved constants

* Keep steering on radar fault (commaai#442)

* Add initial support for Holden/Opel Astra BK (commaai#431)

* Added Astra support to README and RELEASE notes (commaai#443)

* Honda Nidec: avoid giraffe setting alert when car is turned off (commaai#449)

* Adding support for 2018 GMC Acadia Denali (commaai#453)

* added acadia

* adding acadia

* adding acadia

* Update radar_interface.py

* adding acadia

* refactored

* fixed tuning

* Adding acadia

* Update interface.py

* fixed whitespace

* fixed whitespace

* ACC cancel button

* GM: Cadillac ATS Coupe 2018 support (commaai#445)

* GM: Cadillac ATS Coupe 2018 support

* Missed adding Cadillac ATS

* Fixed Capitalization + Made CT6 Comment Cleaner (commaai#456)

* Update README.md

* Updated CT6 comment

* Add Lexus RX450HL as sub to RX450H (commaai#458)

Add Lexus RX450HL as sub to RX450H

* on gas pedal press, send cancel ACC button to cancel OpenPilot

* try sending +1 counter so our message isn't a duplicate

* only do the accel pedal for specific cars

* do accel pedal for all models

* try always sending 1 for cancel acc frame

* clean up comments and remove unused moving_fast

* remove unused make can msg parameters

* try incrementing wheel button counter by 2 to see if that works better for cancel

* Squashed 'opendbc/' changes from 3f6cd74..e108b6b

e108b6b Add more Sign recognitions (commaai#126)
6e8a363 Add GM FCW Alert (Take 2) (commaai#125)
368701a Revert "Add GM FCW dashboard alert (commaai#123)" (commaai#124)
98b5f66 Add GM FCW dashboard alert (commaai#123)
71b7588 Adds dbc for 2019 Honda Insight (commaai#122)

git-subtree-dir: opendbc
git-subtree-split: e108b6b

* Squashed 'pyextra/' changes from fb152de..8cc1594

8cc1594 update overpy
2c18997 switch to forked version of overpy

git-subtree-dir: pyextra
git-subtree-split: 8cc1594238fcae6acb8bcd825ac73bbca586b1be

* openpilot v0.5.7 release

* try to simplify message logic

* clean up code

* move Chrylser into main table in readme

* 0.5.7 hotfixes

* On pedal press, if in steer error state, do not send ACC cancel button message.
Sending the ACC cancel button message in this state causes the car to display warnings.

* set the new ret.openpilotLongitudinalControl = False

* hotfix: wait longer in CDP mode before switching to fast charge, so EON can boot (commaai#469)

* generalize jeep fingerprint to also cover 2017 Jeep Grand Cherokee Trailhawk

* disable pedal_gas for now to do a devel release. Sending 23b might fault other cars.

* add jeep grand cherokee 2017 to readme car list

* separate fingerprint for trailhawk. separate wheelbase for Cherokee
adhintz added a commit to adhintz/openpilot that referenced this pull request Dec 29, 2018
* GM: remove refactor leftovers (commaai#440)

* Move calibration values (commaai#441)

* initial commit

* moved constants

* Keep steering on radar fault (commaai#442)

* Add initial support for Holden/Opel Astra BK (commaai#431)

* Added Astra support to README and RELEASE notes (commaai#443)

* Honda Nidec: avoid giraffe setting alert when car is turned off (commaai#449)

* Adding support for 2018 GMC Acadia Denali (commaai#453)

* added acadia

* adding acadia

* adding acadia

* Update radar_interface.py

* adding acadia

* refactored

* fixed tuning

* Adding acadia

* Update interface.py

* fixed whitespace

* fixed whitespace

* ACC cancel button

* GM: Cadillac ATS Coupe 2018 support (commaai#445)

* GM: Cadillac ATS Coupe 2018 support

* Missed adding Cadillac ATS

* Fixed Capitalization + Made CT6 Comment Cleaner (commaai#456)

* Update README.md

* Updated CT6 comment

* Add Lexus RX450HL as sub to RX450H (commaai#458)

Add Lexus RX450HL as sub to RX450H

* on gas pedal press, send cancel ACC button to cancel OpenPilot

* try sending +1 counter so our message isn't a duplicate

* only do the accel pedal for specific cars

* do accel pedal for all models

* try always sending 1 for cancel acc frame

* clean up comments and remove unused moving_fast

* remove unused make can msg parameters

* try incrementing wheel button counter by 2 to see if that works better for cancel

* Squashed 'opendbc/' changes from 3f6cd74..e108b6b

e108b6b Add more Sign recognitions (commaai#126)
6e8a363 Add GM FCW Alert (Take 2) (commaai#125)
368701a Revert "Add GM FCW dashboard alert (commaai#123)" (commaai#124)
98b5f66 Add GM FCW dashboard alert (commaai#123)
71b7588 Adds dbc for 2019 Honda Insight (commaai#122)

git-subtree-dir: opendbc
git-subtree-split: e108b6b

* Squashed 'pyextra/' changes from fb152de..8cc1594

8cc1594 update overpy
2c18997 switch to forked version of overpy

git-subtree-dir: pyextra
git-subtree-split: 8cc1594238fcae6acb8bcd825ac73bbca586b1be

* openpilot v0.5.7 release

* try to simplify message logic

* clean up code

* move Chrylser into main table in readme

* 0.5.7 hotfixes

* On pedal press, if in steer error state, do not send ACC cancel button message.
Sending the ACC cancel button message in this state causes the car to display warnings.

* set the new ret.openpilotLongitudinalControl = False

* hotfix: wait longer in CDP mode before switching to fast charge, so EON can boot (commaai#469)

* generalize jeep fingerprint to also cover 2017 Jeep Grand Cherokee Trailhawk

* disable pedal_gas for now to do a devel release. Sending 23b might fault other cars.

* add jeep grand cherokee 2017 to readme car list

* separate fingerprint for trailhawk. separate wheelbase for Cherokee

* add fingerprint for Pacifica 2019 Hybrid.
adhintz added a commit to adhintz/openpilot that referenced this pull request Dec 29, 2018
* remove logging from devel

* Revert "remove logging from devel"

This reverts commit 2145747.

* Squashed 'opendbc/' changes from 3f6cd74..e108b6b

e108b6b Add more Sign recognitions (commaai#126)
6e8a363 Add GM FCW Alert (Take 2) (commaai#125)
368701a Revert "Add GM FCW dashboard alert (commaai#123)" (commaai#124)
98b5f66 Add GM FCW dashboard alert (commaai#123)
71b7588 Adds dbc for 2019 Honda Insight (commaai#122)

git-subtree-dir: opendbc
git-subtree-split: e108b6b

* Squashed 'pyextra/' changes from fb152de..8cc1594

8cc1594 update overpy
2c18997 switch to forked version of overpy

git-subtree-dir: pyextra
git-subtree-split: 8cc1594238fcae6acb8bcd825ac73bbca586b1be

* openpilot v0.5.7 release

* 0.5.7 hotfixes

* On pedal press, if in steer error state, do not send ACC cancel button message.
Sending the ACC cancel button message in this state causes the car to display warnings.

* set the new ret.openpilotLongitudinalControl = False

* hotfix: wait longer in CDP mode before switching to fast charge, so EON can boot (commaai#469)

* generalize jeep fingerprint to also cover 2017 Jeep Grand Cherokee Trailhawk

* disable pedal_gas for now to do a devel release. Sending 23b might fault other cars.

* add jeep grand cherokee 2017 to readme car list

* 0.5.7 & Jeep Grand Cherokee 2017 support (#7)

* GM: remove refactor leftovers (commaai#440)

* Move calibration values (commaai#441)

* initial commit

* moved constants

* Keep steering on radar fault (commaai#442)

* Add initial support for Holden/Opel Astra BK (commaai#431)

* Added Astra support to README and RELEASE notes (commaai#443)

* Honda Nidec: avoid giraffe setting alert when car is turned off (commaai#449)

* Adding support for 2018 GMC Acadia Denali (commaai#453)

* added acadia

* adding acadia

* adding acadia

* Update radar_interface.py

* adding acadia

* refactored

* fixed tuning

* Adding acadia

* Update interface.py

* fixed whitespace

* fixed whitespace

* ACC cancel button

* GM: Cadillac ATS Coupe 2018 support (commaai#445)

* GM: Cadillac ATS Coupe 2018 support

* Missed adding Cadillac ATS

* Fixed Capitalization + Made CT6 Comment Cleaner (commaai#456)

* Update README.md

* Updated CT6 comment

* Add Lexus RX450HL as sub to RX450H (commaai#458)

Add Lexus RX450HL as sub to RX450H

* on gas pedal press, send cancel ACC button to cancel OpenPilot

* try sending +1 counter so our message isn't a duplicate

* only do the accel pedal for specific cars

* do accel pedal for all models

* try always sending 1 for cancel acc frame

* clean up comments and remove unused moving_fast

* remove unused make can msg parameters

* try incrementing wheel button counter by 2 to see if that works better for cancel

* Squashed 'opendbc/' changes from 3f6cd74..e108b6b

e108b6b Add more Sign recognitions (commaai#126)
6e8a363 Add GM FCW Alert (Take 2) (commaai#125)
368701a Revert "Add GM FCW dashboard alert (commaai#123)" (commaai#124)
98b5f66 Add GM FCW dashboard alert (commaai#123)
71b7588 Adds dbc for 2019 Honda Insight (commaai#122)

git-subtree-dir: opendbc
git-subtree-split: e108b6b

* Squashed 'pyextra/' changes from fb152de..8cc1594

8cc1594 update overpy
2c18997 switch to forked version of overpy

git-subtree-dir: pyextra
git-subtree-split: 8cc1594238fcae6acb8bcd825ac73bbca586b1be

* openpilot v0.5.7 release

* try to simplify message logic

* clean up code

* move Chrylser into main table in readme

* 0.5.7 hotfixes

* On pedal press, if in steer error state, do not send ACC cancel button message.
Sending the ACC cancel button message in this state causes the car to display warnings.

* set the new ret.openpilotLongitudinalControl = False

* hotfix: wait longer in CDP mode before switching to fast charge, so EON can boot (commaai#469)

* generalize jeep fingerprint to also cover 2017 Jeep Grand Cherokee Trailhawk

* disable pedal_gas for now to do a devel release. Sending 23b might fault other cars.

* add jeep grand cherokee 2017 to readme car list

* separate fingerprint for trailhawk. separate wheelbase for Cherokee

*  separate fingerprint for trailhawk. separate wheelbase for Cherokee (#8)

* GM: remove refactor leftovers (commaai#440)

* Move calibration values (commaai#441)

* initial commit

* moved constants

* Keep steering on radar fault (commaai#442)

* Add initial support for Holden/Opel Astra BK (commaai#431)

* Added Astra support to README and RELEASE notes (commaai#443)

* Honda Nidec: avoid giraffe setting alert when car is turned off (commaai#449)

* Adding support for 2018 GMC Acadia Denali (commaai#453)

* added acadia

* adding acadia

* adding acadia

* Update radar_interface.py

* adding acadia

* refactored

* fixed tuning

* Adding acadia

* Update interface.py

* fixed whitespace

* fixed whitespace

* ACC cancel button

* GM: Cadillac ATS Coupe 2018 support (commaai#445)

* GM: Cadillac ATS Coupe 2018 support

* Missed adding Cadillac ATS

* Fixed Capitalization + Made CT6 Comment Cleaner (commaai#456)

* Update README.md

* Updated CT6 comment

* Add Lexus RX450HL as sub to RX450H (commaai#458)

Add Lexus RX450HL as sub to RX450H

* on gas pedal press, send cancel ACC button to cancel OpenPilot

* try sending +1 counter so our message isn't a duplicate

* only do the accel pedal for specific cars

* do accel pedal for all models

* try always sending 1 for cancel acc frame

* clean up comments and remove unused moving_fast

* remove unused make can msg parameters

* try incrementing wheel button counter by 2 to see if that works better for cancel

* Squashed 'opendbc/' changes from 3f6cd74..e108b6b

e108b6b Add more Sign recognitions (commaai#126)
6e8a363 Add GM FCW Alert (Take 2) (commaai#125)
368701a Revert "Add GM FCW dashboard alert (commaai#123)" (commaai#124)
98b5f66 Add GM FCW dashboard alert (commaai#123)
71b7588 Adds dbc for 2019 Honda Insight (commaai#122)

git-subtree-dir: opendbc
git-subtree-split: e108b6b

* Squashed 'pyextra/' changes from fb152de..8cc1594

8cc1594 update overpy
2c18997 switch to forked version of overpy

git-subtree-dir: pyextra
git-subtree-split: 8cc1594238fcae6acb8bcd825ac73bbca586b1be

* openpilot v0.5.7 release

* try to simplify message logic

* clean up code

* move Chrylser into main table in readme

* 0.5.7 hotfixes

* On pedal press, if in steer error state, do not send ACC cancel button message.
Sending the ACC cancel button message in this state causes the car to display warnings.

* set the new ret.openpilotLongitudinalControl = False

* hotfix: wait longer in CDP mode before switching to fast charge, so EON can boot (commaai#469)

* generalize jeep fingerprint to also cover 2017 Jeep Grand Cherokee Trailhawk

* disable pedal_gas for now to do a devel release. Sending 23b might fault other cars.

* add jeep grand cherokee 2017 to readme car list

* separate fingerprint for trailhawk. separate wheelbase for Cherokee

* add fingerprint for Pacifica 2019 Hybrid.
klaus385 pushed a commit to klaus385/openpilot that referenced this pull request Dec 31, 2018
pd0wm pushed a commit that referenced this pull request Feb 20, 2020
b2ffaae Chrysler: disengage on gas press  (#442)
2ebbe36 Subaru: disengage on gas press (#446)
ccf75c4 Volkswagen safety updates: Phase 1 (#444)

git-subtree-dir: panda
git-subtree-split: b2ffaae
pd0wm pushed a commit that referenced this pull request Feb 21, 2020
598074c Volkswagen safety updates: Phase 2 (#445)
b2ffaae Chrysler: disengage on gas press  (#442)
2ebbe36 Subaru: disengage on gas press (#446)
ccf75c4 Volkswagen safety updates: Phase 1 (#444)

git-subtree-dir: panda
git-subtree-split: 598074c
pd0wm pushed a commit that referenced this pull request Feb 22, 2020
598074c Volkswagen safety updates: Phase 2 (#445)
b2ffaae Chrysler: disengage on gas press  (#442)
2ebbe36 Subaru: disengage on gas press (#446)
ccf75c4 Volkswagen safety updates: Phase 1 (#444)

git-subtree-dir: panda
git-subtree-split: 598074c
pd0wm pushed a commit that referenced this pull request Mar 12, 2020
0696730 Toyota: add missing offset from speed signal (#469)
5b1a8dc Filtering LKAS HUD messages (#468)
99050f4 test_spam_can_buses was missing from Nissan
0f21b19 Cleanup pedal nomenclature (#467)
ceff91d Standardize brake safety tests (#465)
04809e1 Hyundai brake check (#464)
74c8ee0 Subaru brake check (#463)
4ecc6b3 Cleanup: avoid unnecessary bus checks in rx hooks
c7d0d5f Volkswagen safety updates: Phase 3 (#462)
4368748 WIP: Toyota brake check.  (#459)
2ef996f fix addr frequencies
e063b26 Second test fix tentative
88e2593 This should fix the test replay
ebb8866 Added NISSAN replay test
b2dbb50 remove toyota ipas safety code and tests (#460)
a379faf White Panda's Wi-Fi setup instructions (#457)
11ef24b Improve tests (#456)
fb02390 Subaru checksum counter (#455)
9a44499 Fix Subaru Legacy Torque driver bug (#454)
dfa6b07 separating subary legacy safety mode from global (#452)
dad5858 Chrysler: add brakepress cancellation (#451)
db94a5b Added Nissan safety (#244)
d7f1195 Chrysler Checksum/counter (#450)
96e535e abstract crc function (#448)
1b49d3e Hyundai: add gas disengage and tests (#447)
598074c Volkswagen safety updates: Phase 2 (#445)
b2ffaae Chrysler: disengage on gas press  (#442)
2ebbe36 Subaru: disengage on gas press (#446)
ccf75c4 Volkswagen safety updates: Phase 1 (#444)

git-subtree-dir: panda
git-subtree-split: 0696730
pd0wm pushed a commit that referenced this pull request Mar 13, 2020
0696730 Toyota: add missing offset from speed signal (#469)
5b1a8dc Filtering LKAS HUD messages (#468)
99050f4 test_spam_can_buses was missing from Nissan
0f21b19 Cleanup pedal nomenclature (#467)
ceff91d Standardize brake safety tests (#465)
04809e1 Hyundai brake check (#464)
74c8ee0 Subaru brake check (#463)
4ecc6b3 Cleanup: avoid unnecessary bus checks in rx hooks
c7d0d5f Volkswagen safety updates: Phase 3 (#462)
4368748 WIP: Toyota brake check.  (#459)
2ef996f fix addr frequencies
e063b26 Second test fix tentative
88e2593 This should fix the test replay
ebb8866 Added NISSAN replay test
b2dbb50 remove toyota ipas safety code and tests (#460)
a379faf White Panda's Wi-Fi setup instructions (#457)
11ef24b Improve tests (#456)
fb02390 Subaru checksum counter (#455)
9a44499 Fix Subaru Legacy Torque driver bug (#454)
dfa6b07 separating subary legacy safety mode from global (#452)
dad5858 Chrysler: add brakepress cancellation (#451)
db94a5b Added Nissan safety (#244)
d7f1195 Chrysler Checksum/counter (#450)
96e535e abstract crc function (#448)
1b49d3e Hyundai: add gas disengage and tests (#447)
598074c Volkswagen safety updates: Phase 2 (#445)
b2ffaae Chrysler: disengage on gas press  (#442)
2ebbe36 Subaru: disengage on gas press (#446)
ccf75c4 Volkswagen safety updates: Phase 1 (#444)

git-subtree-dir: panda
git-subtree-split: 0696730
pd0wm pushed a commit that referenced this pull request Mar 13, 2020
0696730 Toyota: add missing offset from speed signal (#469)
5b1a8dc Filtering LKAS HUD messages (#468)
99050f4 test_spam_can_buses was missing from Nissan
0f21b19 Cleanup pedal nomenclature (#467)
ceff91d Standardize brake safety tests (#465)
04809e1 Hyundai brake check (#464)
74c8ee0 Subaru brake check (#463)
4ecc6b3 Cleanup: avoid unnecessary bus checks in rx hooks
c7d0d5f Volkswagen safety updates: Phase 3 (#462)
4368748 WIP: Toyota brake check.  (#459)
2ef996f fix addr frequencies
e063b26 Second test fix tentative
88e2593 This should fix the test replay
ebb8866 Added NISSAN replay test
b2dbb50 remove toyota ipas safety code and tests (#460)
a379faf White Panda's Wi-Fi setup instructions (#457)
11ef24b Improve tests (#456)
fb02390 Subaru checksum counter (#455)
9a44499 Fix Subaru Legacy Torque driver bug (#454)
dfa6b07 separating subary legacy safety mode from global (#452)
dad5858 Chrysler: add brakepress cancellation (#451)
db94a5b Added Nissan safety (#244)
d7f1195 Chrysler Checksum/counter (#450)
96e535e abstract crc function (#448)
1b49d3e Hyundai: add gas disengage and tests (#447)
598074c Volkswagen safety updates: Phase 2 (#445)
b2ffaae Chrysler: disengage on gas press  (#442)
2ebbe36 Subaru: disengage on gas press (#446)
ccf75c4 Volkswagen safety updates: Phase 1 (#444)

git-subtree-dir: panda
git-subtree-split: 0696730
pd0wm pushed a commit that referenced this pull request Mar 13, 2020
0696730 Toyota: add missing offset from speed signal (#469)
5b1a8dc Filtering LKAS HUD messages (#468)
99050f4 test_spam_can_buses was missing from Nissan
0f21b19 Cleanup pedal nomenclature (#467)
ceff91d Standardize brake safety tests (#465)
04809e1 Hyundai brake check (#464)
74c8ee0 Subaru brake check (#463)
4ecc6b3 Cleanup: avoid unnecessary bus checks in rx hooks
c7d0d5f Volkswagen safety updates: Phase 3 (#462)
4368748 WIP: Toyota brake check.  (#459)
2ef996f fix addr frequencies
e063b26 Second test fix tentative
88e2593 This should fix the test replay
ebb8866 Added NISSAN replay test
b2dbb50 remove toyota ipas safety code and tests (#460)
a379faf White Panda's Wi-Fi setup instructions (#457)
11ef24b Improve tests (#456)
fb02390 Subaru checksum counter (#455)
9a44499 Fix Subaru Legacy Torque driver bug (#454)
dfa6b07 separating subary legacy safety mode from global (#452)
dad5858 Chrysler: add brakepress cancellation (#451)
db94a5b Added Nissan safety (#244)
d7f1195 Chrysler Checksum/counter (#450)
96e535e abstract crc function (#448)
1b49d3e Hyundai: add gas disengage and tests (#447)
598074c Volkswagen safety updates: Phase 2 (#445)
b2ffaae Chrysler: disengage on gas press  (#442)
2ebbe36 Subaru: disengage on gas press (#446)
ccf75c4 Volkswagen safety updates: Phase 1 (#444)

git-subtree-dir: panda
git-subtree-split: 0696730
pd0wm pushed a commit that referenced this pull request Mar 14, 2020
0696730 Toyota: add missing offset from speed signal (#469)
5b1a8dc Filtering LKAS HUD messages (#468)
99050f4 test_spam_can_buses was missing from Nissan
0f21b19 Cleanup pedal nomenclature (#467)
ceff91d Standardize brake safety tests (#465)
04809e1 Hyundai brake check (#464)
74c8ee0 Subaru brake check (#463)
4ecc6b3 Cleanup: avoid unnecessary bus checks in rx hooks
c7d0d5f Volkswagen safety updates: Phase 3 (#462)
4368748 WIP: Toyota brake check.  (#459)
2ef996f fix addr frequencies
e063b26 Second test fix tentative
88e2593 This should fix the test replay
ebb8866 Added NISSAN replay test
b2dbb50 remove toyota ipas safety code and tests (#460)
a379faf White Panda's Wi-Fi setup instructions (#457)
11ef24b Improve tests (#456)
fb02390 Subaru checksum counter (#455)
9a44499 Fix Subaru Legacy Torque driver bug (#454)
dfa6b07 separating subary legacy safety mode from global (#452)
dad5858 Chrysler: add brakepress cancellation (#451)
db94a5b Added Nissan safety (#244)
d7f1195 Chrysler Checksum/counter (#450)
96e535e abstract crc function (#448)
1b49d3e Hyundai: add gas disengage and tests (#447)
598074c Volkswagen safety updates: Phase 2 (#445)
b2ffaae Chrysler: disengage on gas press  (#442)
2ebbe36 Subaru: disengage on gas press (#446)
ccf75c4 Volkswagen safety updates: Phase 1 (#444)

git-subtree-dir: panda
git-subtree-split: 0696730
pd0wm pushed a commit that referenced this pull request Mar 16, 2020
0696730 Toyota: add missing offset from speed signal (#469)
5b1a8dc Filtering LKAS HUD messages (#468)
99050f4 test_spam_can_buses was missing from Nissan
0f21b19 Cleanup pedal nomenclature (#467)
ceff91d Standardize brake safety tests (#465)
04809e1 Hyundai brake check (#464)
74c8ee0 Subaru brake check (#463)
4ecc6b3 Cleanup: avoid unnecessary bus checks in rx hooks
c7d0d5f Volkswagen safety updates: Phase 3 (#462)
4368748 WIP: Toyota brake check.  (#459)
2ef996f fix addr frequencies
e063b26 Second test fix tentative
88e2593 This should fix the test replay
ebb8866 Added NISSAN replay test
b2dbb50 remove toyota ipas safety code and tests (#460)
a379faf White Panda's Wi-Fi setup instructions (#457)
11ef24b Improve tests (#456)
fb02390 Subaru checksum counter (#455)
9a44499 Fix Subaru Legacy Torque driver bug (#454)
dfa6b07 separating subary legacy safety mode from global (#452)
dad5858 Chrysler: add brakepress cancellation (#451)
db94a5b Added Nissan safety (#244)
d7f1195 Chrysler Checksum/counter (#450)
96e535e abstract crc function (#448)
1b49d3e Hyundai: add gas disengage and tests (#447)
598074c Volkswagen safety updates: Phase 2 (#445)
b2ffaae Chrysler: disengage on gas press  (#442)
2ebbe36 Subaru: disengage on gas press (#446)
ccf75c4 Volkswagen safety updates: Phase 1 (#444)

git-subtree-dir: panda
git-subtree-split: 0696730
pd0wm pushed a commit that referenced this pull request Mar 16, 2020
0696730 Toyota: add missing offset from speed signal (#469)
5b1a8dc Filtering LKAS HUD messages (#468)
99050f4 test_spam_can_buses was missing from Nissan
0f21b19 Cleanup pedal nomenclature (#467)
ceff91d Standardize brake safety tests (#465)
04809e1 Hyundai brake check (#464)
74c8ee0 Subaru brake check (#463)
4ecc6b3 Cleanup: avoid unnecessary bus checks in rx hooks
c7d0d5f Volkswagen safety updates: Phase 3 (#462)
4368748 WIP: Toyota brake check.  (#459)
2ef996f fix addr frequencies
e063b26 Second test fix tentative
88e2593 This should fix the test replay
ebb8866 Added NISSAN replay test
b2dbb50 remove toyota ipas safety code and tests (#460)
a379faf White Panda's Wi-Fi setup instructions (#457)
11ef24b Improve tests (#456)
fb02390 Subaru checksum counter (#455)
9a44499 Fix Subaru Legacy Torque driver bug (#454)
dfa6b07 separating subary legacy safety mode from global (#452)
dad5858 Chrysler: add brakepress cancellation (#451)
db94a5b Added Nissan safety (#244)
d7f1195 Chrysler Checksum/counter (#450)
96e535e abstract crc function (#448)
1b49d3e Hyundai: add gas disengage and tests (#447)
598074c Volkswagen safety updates: Phase 2 (#445)
b2ffaae Chrysler: disengage on gas press  (#442)
2ebbe36 Subaru: disengage on gas press (#446)
ccf75c4 Volkswagen safety updates: Phase 1 (#444)

git-subtree-dir: panda
git-subtree-split: 0696730
pd0wm pushed a commit that referenced this pull request Mar 16, 2020
0696730 Toyota: add missing offset from speed signal (#469)
5b1a8dc Filtering LKAS HUD messages (#468)
99050f4 test_spam_can_buses was missing from Nissan
0f21b19 Cleanup pedal nomenclature (#467)
ceff91d Standardize brake safety tests (#465)
04809e1 Hyundai brake check (#464)
74c8ee0 Subaru brake check (#463)
4ecc6b3 Cleanup: avoid unnecessary bus checks in rx hooks
c7d0d5f Volkswagen safety updates: Phase 3 (#462)
4368748 WIP: Toyota brake check.  (#459)
2ef996f fix addr frequencies
e063b26 Second test fix tentative
88e2593 This should fix the test replay
ebb8866 Added NISSAN replay test
b2dbb50 remove toyota ipas safety code and tests (#460)
a379faf White Panda's Wi-Fi setup instructions (#457)
11ef24b Improve tests (#456)
fb02390 Subaru checksum counter (#455)
9a44499 Fix Subaru Legacy Torque driver bug (#454)
dfa6b07 separating subary legacy safety mode from global (#452)
dad5858 Chrysler: add brakepress cancellation (#451)
db94a5b Added Nissan safety (#244)
d7f1195 Chrysler Checksum/counter (#450)
96e535e abstract crc function (#448)
1b49d3e Hyundai: add gas disengage and tests (#447)
598074c Volkswagen safety updates: Phase 2 (#445)
b2ffaae Chrysler: disengage on gas press  (#442)
2ebbe36 Subaru: disengage on gas press (#446)
ccf75c4 Volkswagen safety updates: Phase 1 (#444)

git-subtree-dir: panda
git-subtree-split: 0696730
dragonpilot pushed a commit to dragonpilot-community/dragonpilot that referenced this pull request Apr 7, 2020
Vaggysag pushed a commit to Vaggysag/openpilot that referenced this pull request Apr 21, 2020
* add gas cancellation for chrysler
* added regr test too
* also add bus checks to chrysler. SHould have been there already
dzid26 added a commit to dzid26/openpilot-for-BMW-E8x-E9x that referenced this pull request Jan 2, 2022
d32345dd Removed prints that were used for test, but cannot be compiled for the target
ba74138 Added BMW safety tests. Updated safety to limit maximum commanded target delta. Fixed safety bugs with speed scaling and other type bugs.
d3cde431 Testing helpers
c4c8cce7 Added dummy state to gmlan testing
9a2e2d6c Reduced repeated code
e1aef2e1 Made compatible with d301a59
ed075850 Merge branch 'master' of https://github.com/commaai/panda
437d7ac2 BMW hooks. Number commaai#12 used for safety.
74c8ee0 Subaru brake check (commaai#463)
4ecc6b3 Cleanup: avoid unnecessary bus checks in rx hooks
c7d0d5f Volkswagen safety updates: Phase 3 (commaai#462)
4368748 WIP: Toyota brake check.  (commaai#459)
2ef996f fix addr frequencies
e063b26 Second test fix tentative
88e2593 This should fix the test replay
ebb8866 Added NISSAN replay test
b2dbb50 remove toyota ipas safety code and tests (commaai#460)
a379faf White Panda's Wi-Fi setup instructions (commaai#457)
11ef24b Improve tests (commaai#456)
fb02390 Subaru checksum counter (commaai#455)
9a44499 Fix Subaru Legacy Torque driver bug (commaai#454)
dfa6b07 separating subary legacy safety mode from global (commaai#452)
dad5858 Chrysler: add brakepress cancellation (commaai#451)
db94a5b Added Nissan safety (commaai#244)
f88af30e Merge remote-tracking branch 'remotes/Comma/master'
d7f1195 Chrysler Checksum/counter (commaai#450)
96e535e abstract crc function (commaai#448)
1b49d3e Hyundai: add gas disengage and tests (commaai#447)
598074c Volkswagen safety updates: Phase 2 (commaai#445)
b2ffaae Chrysler: disengage on gas press  (commaai#442)
2ebbe36 Subaru: disengage on gas press (commaai#446)
ccf75c4 Volkswagen safety updates: Phase 1 (commaai#444)
d686a2ce Fixed GMLAN switch tickle interrupt

git-subtree-dir: panda
git-subtree-split: d32345ddcf9f70872b54886fc6c949c20dcc8650
dzid26 added a commit to dzid26/openpilot-for-BMW-E8x-E9x that referenced this pull request Feb 22, 2022
d32345dd Removed prints that were used for test, but cannot be compiled for the target
ba74138 Added BMW safety tests. Updated safety to limit maximum commanded target delta. Fixed safety bugs with speed scaling and other type bugs.
d3cde431 Testing helpers
c4c8cce7 Added dummy state to gmlan testing
9a2e2d6c Reduced repeated code
e1aef2e1 Made compatible with d301a59
ed075850 Merge branch 'master' of https://github.com/commaai/panda
437d7ac2 BMW hooks. Number commaai#12 used for safety.
74c8ee0 Subaru brake check (commaai#463)
4ecc6b3 Cleanup: avoid unnecessary bus checks in rx hooks
c7d0d5f Volkswagen safety updates: Phase 3 (commaai#462)
4368748 WIP: Toyota brake check.  (commaai#459)
2ef996f fix addr frequencies
e063b26 Second test fix tentative
88e2593 This should fix the test replay
ebb8866 Added NISSAN replay test
b2dbb50 remove toyota ipas safety code and tests (commaai#460)
a379faf White Panda's Wi-Fi setup instructions (commaai#457)
11ef24b Improve tests (commaai#456)
fb02390 Subaru checksum counter (commaai#455)
9a44499 Fix Subaru Legacy Torque driver bug (commaai#454)
dfa6b07 separating subary legacy safety mode from global (commaai#452)
dad5858 Chrysler: add brakepress cancellation (commaai#451)
db94a5b Added Nissan safety (commaai#244)
f88af30e Merge remote-tracking branch 'remotes/Comma/master'
d7f1195 Chrysler Checksum/counter (commaai#450)
96e535e abstract crc function (commaai#448)
1b49d3e Hyundai: add gas disengage and tests (commaai#447)
598074c Volkswagen safety updates: Phase 2 (commaai#445)
b2ffaae Chrysler: disengage on gas press  (commaai#442)
2ebbe36 Subaru: disengage on gas press (commaai#446)
ccf75c4 Volkswagen safety updates: Phase 1 (commaai#444)
d686a2ce Fixed GMLAN switch tickle interrupt

git-subtree-dir: panda
git-subtree-split: d32345ddcf9f70872b54886fc6c949c20dcc8650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants