Bounty: FlexRay adapter #463

nanamiwang · 2018-12-11T12:32:23Z

FlexRay adapter based on MPC5748G chip, passed basic FlexRay communication tests between two MPC5748G DEVKIT boards.
For more information, please refer to the README doc:
https://github.com/nanamiwang/openpilot/blob/flexray_bounty/flexray_adapter/README.md

rbiasini · 2018-12-11T19:44:30Z

@nanamiwang this looks amazing work. It will take a while to go through it. Thanks!
The bounty is locked.

TheMutley · 2018-12-11T20:57:30Z

I have actual Flexray log from a car and the hardware to read/write to the FR bus. Let me know if you need any help.

nanamiwang · 2018-12-12T05:39:46Z

I have actual Flexray log from a car and the hardware to read/write to the FR bus. Let me know if you need any help.
@TheMutley The Flexray log is definitely helpful, can you send the log to me or share it on slack? I'd like to do some analysis and share the result.

ghostriding · 2018-12-12T21:48:18Z

nice work:)

TheMutley · 2018-12-30T16:46:23Z

@nanamiwang sorry for the delay, here's a Flexray log from an i3 driving on ACC with a FR channel and the powetrain CAN.

BMWi3ACCHighwayDrive.zip

nanamiwang · 2019-01-01T14:39:26Z

@TheMutley thanks.

rbiasini · 2019-01-18T02:33:37Z

@nanamiwang , in 2-3 months we will do a openpilot port to a car that uses FlexRay (we have a nice Cadillac CT6 :)), possibly by leveraging this work. So that would be a way to verify this PR and unlock the bounty. Alternatively, any verification from the community would also be ok.

nanamiwang · 2019-01-18T05:07:51Z

@rbiasini this is ok for me, take your time. I am trying AUDI A4 porting to verify my work.
BTW, a question, why the official AUDI A4 porting bounty is removed? Bounty will encourage me to work more time on this.

rbiasini · 2019-01-18T08:04:27Z

Ah, yes, we removed it 8 months ago. It was probably removed because we bought the CT6 and we plan to do the port ourselves. I can put a bounty back, specific for Audi.

nanamiwang · 2019-01-18T09:20:53Z

Wow, it will be great.

skycocker · 2019-02-06T15:11:54Z

This would be so useful. Does anybody have a clue where to look for a flexray socket in a car? I believe I have 2 cars which should have one, I just have no idea where.

cryptedx · 2019-02-06T18:13:54Z

@nanamiwang , in 2-3 months we will do a openpilot port to a car that uses FlexRay (we have a nice Cadillac CT6 :)), possibly by leveraging this work. So that would be a way to verify this PR and unlock the bounty. Alternatively, any verification from the community would also be ok.

Verification will be done with my A4 :-D

This would be so useful. Does anybody have a clue where to look for a flexray socket in a car? I believe I have 2 cars which should have one, I just have no idea where.

There is no standard flexray socket in a car. You have to look at wiring diagrams at your car.

Anyway, I don't think that this place is the right one to speak about such things (offtopic). Please join us at discord. Thank you.

BrackoNe · 2019-04-16T17:09:29Z

Can I provide some data, I have F34 (2015) and my car has lane assist, Park Distance Control PDC, Automatic Transmission, blind spot sensor and adaptive cruise control. Can I provide some of data to help this development?

triscb82 · 2019-06-01T14:44:33Z

I live in Harrisburg, PA and have a 2018 BMW 540d xdrive fully loaded with all driving assist packages that I would be willing to allow use of as a guinea pig in exchange for making it work!

nanamiwang · 2019-06-11T05:15:31Z

@triscb82 Great, feel free to join #topic-flexray channel on comma discord server.

zizo1111 · 2019-07-23T14:49:57Z

@nanamiwang Nice work, I have been trying to test the Adapter on a Vehicle, but it seems that there is a problem as i am not able to read all the frames. I can read only the frames with an even slot (cycle) Also I can't get the debugger to send readable messagges in oder to track the problem. I have writen you an email and i was hoping that you can help.
Thanks

cryptedx · 2019-07-23T15:52:19Z

@zizo1111 We are currently in alpha status. Please don't expect it to work. The development is going on every day, but it takes time. It is an extremely complicated topic!

What's you car?

0696730 Toyota: add missing offset from speed signal (#469) 5b1a8dc Filtering LKAS HUD messages (#468) 99050f4 test_spam_can_buses was missing from Nissan 0f21b19 Cleanup pedal nomenclature (#467) ceff91d Standardize brake safety tests (#465) 04809e1 Hyundai brake check (#464) 74c8ee0 Subaru brake check (#463) 4ecc6b3 Cleanup: avoid unnecessary bus checks in rx hooks c7d0d5f Volkswagen safety updates: Phase 3 (#462) 4368748 WIP: Toyota brake check. (#459) 2ef996f fix addr frequencies e063b26 Second test fix tentative 88e2593 This should fix the test replay ebb8866 Added NISSAN replay test b2dbb50 remove toyota ipas safety code and tests (#460) a379faf White Panda's Wi-Fi setup instructions (#457) 11ef24b Improve tests (#456) fb02390 Subaru checksum counter (#455) 9a44499 Fix Subaru Legacy Torque driver bug (#454) dfa6b07 separating subary legacy safety mode from global (#452) dad5858 Chrysler: add brakepress cancellation (#451) db94a5b Added Nissan safety (#244) d7f1195 Chrysler Checksum/counter (#450) 96e535e abstract crc function (#448) 1b49d3e Hyundai: add gas disengage and tests (#447) 598074c Volkswagen safety updates: Phase 2 (#445) b2ffaae Chrysler: disengage on gas press (#442) 2ebbe36 Subaru: disengage on gas press (#446) ccf75c4 Volkswagen safety updates: Phase 1 (#444) git-subtree-dir: panda git-subtree-split: 0696730

* WIP: subaru brake check * FInalized logic and added tests to Subaru brake check

d32345dd Removed prints that were used for test, but cannot be compiled for the target ba74138 Added BMW safety tests. Updated safety to limit maximum commanded target delta. Fixed safety bugs with speed scaling and other type bugs. d3cde431 Testing helpers c4c8cce7 Added dummy state to gmlan testing 9a2e2d6c Reduced repeated code e1aef2e1 Made compatible with d301a59 ed075850 Merge branch 'master' of https://github.com/commaai/panda 437d7ac2 BMW hooks. Number commaai#12 used for safety. 74c8ee0 Subaru brake check (commaai#463) 4ecc6b3 Cleanup: avoid unnecessary bus checks in rx hooks c7d0d5f Volkswagen safety updates: Phase 3 (commaai#462) 4368748 WIP: Toyota brake check. (commaai#459) 2ef996f fix addr frequencies e063b26 Second test fix tentative 88e2593 This should fix the test replay ebb8866 Added NISSAN replay test b2dbb50 remove toyota ipas safety code and tests (commaai#460) a379faf White Panda's Wi-Fi setup instructions (commaai#457) 11ef24b Improve tests (commaai#456) fb02390 Subaru checksum counter (commaai#455) 9a44499 Fix Subaru Legacy Torque driver bug (commaai#454) dfa6b07 separating subary legacy safety mode from global (commaai#452) dad5858 Chrysler: add brakepress cancellation (commaai#451) db94a5b Added Nissan safety (commaai#244) f88af30e Merge remote-tracking branch 'remotes/Comma/master' d7f1195 Chrysler Checksum/counter (commaai#450) 96e535e abstract crc function (commaai#448) 1b49d3e Hyundai: add gas disengage and tests (commaai#447) 598074c Volkswagen safety updates: Phase 2 (commaai#445) b2ffaae Chrysler: disengage on gas press (commaai#442) 2ebbe36 Subaru: disengage on gas press (commaai#446) ccf75c4 Volkswagen safety updates: Phase 1 (commaai#444) d686a2ce Fixed GMLAN switch tickle interrupt git-subtree-dir: panda git-subtree-split: d32345ddcf9f70872b54886fc6c949c20dcc8650

emaba · 2023-12-31T15:54:49Z

Is it still under development? Will there ever be a FlexRay integration?

triscb82 · 2023-12-31T16:12:42Z

I would not count on it. The guy who was helping me dropped off the project.

…

On Sun, Dec 31, 2023 at 10:55 AM Emanuele Baglini ***@***.***> wrote: Is it still under development? Will there ever be a FlexRay integration? — Reply to this email directly, view it on GitHub <#463 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AB5VK4ZE4GIPJKEU5ONSODDYMGDFNAVCNFSM4GJVH7UKU5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOBXGI4TQMJQHEYA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

emaba · 2023-12-31T16:25:42Z

I would not count on it. The guy who was helping me dropped off the project.

It's unfortunate.
I hope that someone will try to integrate FlexRay into Openpilot again.

zm0612 · 2024-05-24T03:21:39Z

I also hope that someone will try to integrate FlexRay into Openpilot again.

nanamiwang added 6 commits December 11, 2018 15:47

Add FlexRay code

a86682f

Fix saving config crash, parse deviation as signed integer

4ea886b

Add car hacking guide in README, Correct line seperator

fc3c6a3

Fix incorrect ZMQ port

abca6c8

Remove binary file

dec1544

Correct typo

83d394f

Fix incorrect S32DS SDK installation guide

814d71c

Fix incorrect display of message buffer channel config

41be33e

nanamiwang added 2 commits February 25, 2019 19:24

Add param pdMaxDrift, remove topology params

33df796

Fix incorrect info for ip address setting

867e326

geohot added the enhancement label Jun 7, 2019

nanamiwang closed this Jun 11, 2019

nanamiwang reopened this Jun 11, 2019

Vaggysag pushed a commit to Vaggysag/openpilot that referenced this pull request Apr 21, 2020

Subaru brake check (commaai#463)

74c8ee0

* WIP: subaru brake check * FInalized logic and added tests to Subaru brake check

rpaulhanna pushed a commit to rpaulhanna/openpilot that referenced this pull request Sep 3, 2021

fix obscenely slow acceleration with pedal (commaai#463)

8697914

rpaulhanna pushed a commit to rpaulhanna/openpilot that referenced this pull request Sep 3, 2021

fix obscenely slow acceleration with pedal (commaai#463)

36cc94c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bounty: FlexRay adapter #463

Bounty: FlexRay adapter #463

nanamiwang commented Dec 11, 2018

rbiasini commented Dec 11, 2018 •

edited

Loading

TheMutley commented Dec 11, 2018

nanamiwang commented Dec 12, 2018

ghostriding commented Dec 12, 2018

TheMutley commented Dec 30, 2018

nanamiwang commented Jan 1, 2019

rbiasini commented Jan 18, 2019

nanamiwang commented Jan 18, 2019

rbiasini commented Jan 18, 2019

nanamiwang commented Jan 18, 2019

skycocker commented Feb 6, 2019

cryptedx commented Feb 6, 2019 •

edited

Loading

BrackoNe commented Apr 16, 2019

triscb82 commented Jun 1, 2019

nanamiwang commented Jun 11, 2019

zizo1111 commented Jul 23, 2019

cryptedx commented Jul 23, 2019

emaba commented Dec 31, 2023

triscb82 commented Dec 31, 2023 via email

emaba commented Dec 31, 2023

zm0612 commented May 24, 2024

Bounty: FlexRay adapter #463

Bounty: FlexRay adapter #463

Conversation

nanamiwang commented Dec 11, 2018

rbiasini commented Dec 11, 2018 • edited Loading

TheMutley commented Dec 11, 2018

nanamiwang commented Dec 12, 2018

ghostriding commented Dec 12, 2018

TheMutley commented Dec 30, 2018

nanamiwang commented Jan 1, 2019

rbiasini commented Jan 18, 2019

nanamiwang commented Jan 18, 2019

rbiasini commented Jan 18, 2019

nanamiwang commented Jan 18, 2019

skycocker commented Feb 6, 2019

cryptedx commented Feb 6, 2019 • edited Loading

BrackoNe commented Apr 16, 2019

triscb82 commented Jun 1, 2019

nanamiwang commented Jun 11, 2019

zizo1111 commented Jul 23, 2019

cryptedx commented Jul 23, 2019

emaba commented Dec 31, 2023

triscb82 commented Dec 31, 2023 via email

emaba commented Dec 31, 2023

zm0612 commented May 24, 2024

rbiasini commented Dec 11, 2018 •

edited

Loading

cryptedx commented Feb 6, 2019 •

edited

Loading