New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `stack build` options to `stack ghci`? #1186

Closed
danclien opened this Issue Oct 17, 2015 · 6 comments

Comments

Projects
None yet
4 participants
@danclien

danclien commented Oct 17, 2015

It looks like a stack ghci will invoke a stack build without any addition options?

I normally build with stack build --executable-profiling. When I run stack ghci, it has to unregister everything in my local database and rebuild everything without profiling.

Would it be possible to add the options from stack build to stack ghci? I'm currently running v0.1.6.0 (e22271f, OS X x86_64).

@bergmark

This comment has been minimized.

Member

bergmark commented Oct 20, 2015

@mgsloan

This comment has been minimized.

Collaborator

mgsloan commented Oct 28, 2015

This is a good idea! It would also be good to have stack ghci follow stack build's convention of defaulting to only building libraries and executables - see this comment #817 (comment).

@borsboom

This comment has been minimized.

Contributor

borsboom commented Oct 29, 2015

Yeah, I agree. Becomes even more relevant with #1228.

@mgsloan

This comment has been minimized.

Collaborator

mgsloan commented Nov 11, 2015

I'm going to go ahead with this, but not looking forward to what it will do to stack ghci --help (See #1333)

@mgsloan

This comment has been minimized.

Collaborator

mgsloan commented Nov 11, 2015

@danclien This is now implemented!

@mgsloan mgsloan closed this Nov 11, 2015

dysinger added a commit that referenced this issue Nov 13, 2015

Merge branch 'master' into sig-sign-sdist-and-upload-sign
* master: (96 commits)
  Revert "Additional helper to get project config dir"
  Additional helper to get project config dir
  Add a few items to ChangeLog.md
  Add stack build options to stack ghci #1186
  Always build exes, due to cabal copy limitation
  Ported stack_and_ghcjs wiki page to doc
  release script: fix compile warnings
  Fix/add documentation for bcWorkDir and workDirRel
  Organize Stack.Types.Config
  Remove unused functions from Stack.Types.Config
  Fix building tests/benches in some circumstances
  Refactor generateHaddockIndex
  Enhance documentation for Stack.Build.Haddock
  Fix haddock generation
  Enhance documentation for System.Process.Read
  Enhance documentation for System.Process.Run
  Refactorings using mapMaybeM, forMaybeM and forMaybeA
  quite a few cosmetic improvements
  Enhance haddocks for Stack.Build.Execute
  Revert "Only install exes when they're built"
  ...
@danclien

This comment has been minimized.

danclien commented Nov 15, 2015

Awesome. Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment