-
Notifications
You must be signed in to change notification settings - Fork 849
Pull bindings-uname package into Stack and fix it to work with FreeBSD. #4238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@mgsloan can you take a look at this PR ? |
Looks like a reasonable change to me. I think it would be better to fix the |
I've never worked with Hackage. How can I update |
It hasn't been updated since 2009, and there's no website, though the git repo still works. Ping the maintainer an email? Edit: relevant haskell-infra/hackage-trustees#79 |
Done that 8 days ago. |
Yeah, I think this package needs a new maintainer. If you're willing to do it, there's a process on the hackage site. The upshot of that is, I think we should merge the PR (subject to code review) and then when there's a new maintainer, migrate to the new code. Which were the changes you made from the original |
Here is the patch: http://arrowd.name/uname.patch |
Thanks. I'd ideally like to see that as two separate commits.
Is this because there's no binary version of stack that works and so you can't bootstrap to test the changes? We should be getting a static build of stack again, soon — would that be helpful on that front? It might be good to prioritize the fix to #3515 at the same time so it can be tested. That issue mentions the fix by @Blaisorblade for OpenBSD in 3cd92c8. Would it be possible to do a similar thing here? |
It has been tested by CI, it's all green. Doesn't that count? |
It does count, although the integration tests aren't run by CI. I've asked maintainers to comment, but I think this will be OK to merge. |
I think it's OK to merge. |
I just found out that this PR also didn't make it into I hope, this will be included in the next Stack release. |
Due to #3515 I wasn't able to test if Stack builds with this change, but changes made for
bindings-uname
do work.