Skip to content

Conversation

dtoki
Copy link
Contributor

@dtoki dtoki commented Apr 9, 2021

Closes #3 & #15

Builds on @songsc work #15; addresses @bmonkman comments.

@dtoki dtoki requested a review from a team as a code owner April 9, 2021 04:14
@dtoki dtoki force-pushed the 3-twilio-support branch 4 times, most recently from e8be97c to 4780660 Compare April 9, 2021 15:29
@dtoki
Copy link
Contributor Author

dtoki commented Apr 9, 2021

Would this also close commitdev/zero#244?

or is the backend example still needed? I could go ahead and do that.

@bmonkman
Copy link
Contributor

bmonkman commented Apr 9, 2021

Yeah I think it can close 244 as well.

@bmonkman
Copy link
Contributor

bmonkman commented Apr 9, 2021

Looks good, thanks! Can you please also bump the version in Chart.yaml so we can use the new helm chart values? You can also bump up the app version in that file to represent the new version of the app that will be released.

@dtoki
Copy link
Contributor Author

dtoki commented Apr 9, 2021

Closes commitdev/zero#244

 * wrap response in json
 * cleanup and suggested fixes
 * bump version for releasea

co-author: songsc <songscijnfan@hotmail.com>
@dtoki dtoki force-pushed the 3-twilio-support branch from 70d7999 to d611c75 Compare April 9, 2021 21:41
@dtoki dtoki requested a review from bmonkman April 9, 2021 21:47
@bmonkman bmonkman merged commit e4b7210 into commitdev:main Apr 9, 2021
@bmonkman bmonkman mentioned this pull request Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add twilio support to notification service
2 participants