Skip to content

Conversation

GlassOfWhiskey
Copy link
Contributor

This property loads schemas in a Graph object. This feature can be
used for CWL file formats checking.

@GlassOfWhiskey GlassOfWhiskey force-pushed the schema-graph-loader branch 5 times, most recently from 6f45eb9 to e055393 Compare August 20, 2022 08:33
@mr-c mr-c changed the title Added graph property to LoadingOptions pycodegen: Added graph property to LoadingOptions Aug 20, 2022
@lgtm-com
Copy link

lgtm-com bot commented Aug 20, 2022

This pull request introduces 2 alerts when merging ee04a03 into 9bf271d - view on LGTM.com

new alerts:

  • 2 for Unused import

@codecov
Copy link

codecov bot commented Aug 20, 2022

Codecov Report

Merging #583 (8af9d35) into main (2de4281) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main     #583      +/-   ##
==========================================
- Coverage   83.08%   83.07%   -0.02%     
==========================================
  Files          20       20              
  Lines        3938     3947       +9     
  Branches     1100     1104       +4     
==========================================
+ Hits         3272     3279       +7     
- Misses        430      432       +2     
  Partials      236      236              
Impacted Files Coverage Δ
schema_salad/fetcher.py 63.96% <80.00%> (+1.21%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lgtm-com
Copy link

lgtm-com bot commented Aug 20, 2022

This pull request introduces 2 alerts when merging 42b4684 into 9bf271d - view on LGTM.com

new alerts:

  • 2 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Aug 20, 2022

This pull request introduces 2 alerts when merging 4115757 into 9bf271d - view on LGTM.com

new alerts:

  • 2 for Unused import

@mr-c
Copy link
Member

mr-c commented Aug 20, 2022

Looking good! I'll wait to see tests here or in a cwl-utils PR that uses this

@mr-c mr-c force-pushed the schema-graph-loader branch from f66e715 to 295195b Compare August 24, 2022 09:08
Copy link
Member

@mr-c mr-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

schema_salad/fetcher.py:20: D101: Missing docstring in public class
schema_salad/fetcher.py:39: D101: Missing docstring in public class
schema_salad/fetcher.py:40: D107: Missing docstring in init
schema_salad/fetcher.py:44: D101: Missing docstring in public class
schema_salad/metaschema.py (100%)
schema_salad/python_codegen_support.py (100%)
schema_salad/tests/test_python_codegen.py (90.6%):
schema_salad/tests/test_python_codegen.py:101: D103: Missing docstring in public function
schema_salad/tests/test_python_codegen.py:112: D103: Missing docstring in public function
schema_salad/tests/test_python_codegen.py:120: D103: Missing docstring in public function

@GlassOfWhiskey
Copy link
Contributor Author

GlassOfWhiskey commented Aug 24, 2022

schema_salad/fetcher.py:20: D101: Missing docstring in public class schema_salad/fetcher.py:39: D101: Missing docstring in public class schema_salad/fetcher.py:40: D107: Missing docstring in init schema_salad/fetcher.py:44: D101: Missing docstring in public class schema_salad/metaschema.py (100%) schema_salad/python_codegen_support.py (100%) schema_salad/tests/test_python_codegen.py (90.6%): schema_salad/tests/test_python_codegen.py:101: D103: Missing docstring in public function schema_salad/tests/test_python_codegen.py:112: D103: Missing docstring in public function schema_salad/tests/test_python_codegen.py:120: D103: Missing docstring in public function

Docstrings are missing everywhere in this repo. Do you want me to be the pioneer of Schema Salad documentators? XD

@GlassOfWhiskey
Copy link
Contributor Author

BTW, I documented the tests. For the Fetcher classes, I'll leave the honors to someone of the developers. Also, since it is a hierarchy it would be nice to propagate docs from top to bottom or the other way round, but I don't know if some kind of Doc inheritance exists in Python

@GlassOfWhiskey
Copy link
Contributor Author

It would be nice to propagate docs from top to bottom or the other way round, but I don't know if some kind of Doc inheritance exists in Python.

Starting from Python 3.5 docstrings are inherited when a subclass doesn't define a new one. Therefore, I only commented classes, constructors and the methods in the Fetcher class (all but the urljoin method, which is not totally clear to me).

@mr-c mr-c merged commit b9bc69a into main Aug 25, 2022
@mr-c mr-c deleted the schema-graph-loader branch August 25, 2022 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants