-
-
Notifications
You must be signed in to change notification settings - Fork 61
pycodegen: Added graph property to LoadingOptions #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6f45eb9
to
e055393
Compare
This pull request introduces 2 alerts when merging ee04a03 into 9bf271d - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## main #583 +/- ##
==========================================
- Coverage 83.08% 83.07% -0.02%
==========================================
Files 20 20
Lines 3938 3947 +9
Branches 1100 1104 +4
==========================================
+ Hits 3272 3279 +7
- Misses 430 432 +2
Partials 236 236
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This pull request introduces 2 alerts when merging 42b4684 into 9bf271d - view on LGTM.com new alerts:
|
This pull request introduces 2 alerts when merging 4115757 into 9bf271d - view on LGTM.com new alerts:
|
Looking good! I'll wait to see tests here or in a cwl-utils PR that uses this |
c3d444e
to
f66e715
Compare
This property loads schemas in a Graph object. This feature can be used for CWL file formats checking.
The `rdfa` format has been removed from RDFLib 5.0.0 onward (see https://rdflib.readthedocs.io/en/stable/upgrade4to5.html#removed-rdf-parsers)
Co-authored-by: Michael R. Crusoe <1330696+mr-c@users.noreply.github.com>
f66e715
to
295195b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
schema_salad/fetcher.py:20: D101: Missing docstring in public class
schema_salad/fetcher.py:39: D101: Missing docstring in public class
schema_salad/fetcher.py:40: D107: Missing docstring in init
schema_salad/fetcher.py:44: D101: Missing docstring in public class
schema_salad/metaschema.py (100%)
schema_salad/python_codegen_support.py (100%)
schema_salad/tests/test_python_codegen.py (90.6%):
schema_salad/tests/test_python_codegen.py:101: D103: Missing docstring in public function
schema_salad/tests/test_python_codegen.py:112: D103: Missing docstring in public function
schema_salad/tests/test_python_codegen.py:120: D103: Missing docstring in public function
Docstrings are missing everywhere in this repo. Do you want me to be the pioneer of Schema Salad documentators? XD |
BTW, I documented the tests. For the |
0d06608
to
290739d
Compare
290739d
to
8af9d35
Compare
Starting from Python 3.5 docstrings are inherited when a subclass doesn't define a new one. Therefore, I only commented classes, constructors and the methods in the |
This property loads schemas in a Graph object. This feature can be
used for CWL file formats checking.