implement support for vFile:mode
and vFile:size
packets
#141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Implement responses to the
vFile:mode
andvFile:size
packets in ds2 platform and debug server sessions. Fully addresses issue #136.Overview
File::fileMode
support to theHost::File
interfaceHost::File::fileMode
usingstat(2)
Host::File::fileMode
SessionDelegate::onFileGetSize
method inFileOperationsMixin
to call the exitingHost::File::fileSize
methodSessionDelegate::onFileGetMode
method and override it inFileOperationsMixin
to call the newHost::File::fileMode
methodvFile:size
to match the lldb documentation.Problem Details
DS2 does not properly implement responses to the
vFile:mode
andvFile:size
packets. These packets are documented here. Most of the pieces forvFile:size
were already present, but they were not all tied together.Validation
With some other uncommitted local patches, verify the following lldb test cases pass on Android and Linux:
These test cases will be re-enabled in CI testing after this and a number of other patches are merged.