Skip to content

Conversation

andrurogerz
Copy link
Collaborator

@andrurogerz andrurogerz commented Oct 4, 2024

Purpose

The FreeBSD build was silently failing for a week or so but the GitHub build job was succeeding anyway. This looks like a quirk in the vmactions/freebsd-vm action, where it reports the exit code of the last command run. This PR ensures the last command run is actually the cmake --build command.

Overview

  • Move the tar command for the build output out of the VM and back to the job runner to ensure the last command run in the VM is cmake --build.
  • Fix the build error introduced by 0cf4f74 by renaming FreeBSD's Platform::GetOSKernelPath with Platform::GetOSKernelVersion as was done for Linux.
  • Update FreeBSD's Platform::GetOSBuild to report uname's release string rather than version, as was previously done for Linux.

Validation

Confirmed the FreeBSD build breaks in its current state by applying 0cf4f74 only.

@compnerd compnerd merged commit ad33b38 into compnerd:main Oct 4, 2024
23 checks passed
@andrurogerz andrurogerz deleted the fredbsd-fail-build branch October 4, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants