[gha] ensure the FreeBSD build job fails when there are compilation failures #144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The FreeBSD build was silently failing for a week or so but the GitHub build job was succeeding anyway. This looks like a quirk in the
vmactions/freebsd-vm
action, where it reports the exit code of the last command run. This PR ensures the last command run is actually thecmake --build
command.Overview
tar
command for the build output out of the VM and back to the job runner to ensure the last command run in the VM iscmake --build
.Platform::GetOSKernelPath
withPlatform::GetOSKernelVersion
as was done for Linux.Platform::GetOSBuild
to reportuname
'srelease
string rather thanversion
, as was previously done for Linux.Validation
Confirmed the FreeBSD build breaks in its current state by applying 0cf4f74 only.