Skip to content

[gha] ensure the FreeBSD build job fails when there are compilation failures #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 4, 2024
Merged

[gha] ensure the FreeBSD build job fails when there are compilation failures #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d2d906
[gha] tar the build output outside of the freebsd vm
andrurogerz Oct 4, 2024
e357a58
[freebsd] fix build due to missing GetOSKernelPath
andrurogerz Oct 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,10 @@ jobs:
-G Ninja \
-S ${{ github.workspace }}/SourceCache/ds2
cmake --build ${{ github.workspace }}/BinaryCache/ds2 --config Release
tar -C ${{ github.workspace }}/BinaryCache -cvf ${{ github.workspace }}/BinaryCache/ds2.tar ds2

# Tar the output to preserve permissions.
- name: tar output
run: tar -C ${{ github.workspace }}/BinaryCache -cvf ${{ github.workspace }}/BinaryCache/ds2.tar ds2

- uses: actions/upload-artifact@v4
with:
Expand Down
4 changes: 2 additions & 2 deletions Sources/Host/FreeBSD/Platform.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,9 @@ static struct utsname const *GetCachedUTSName() {

char const *Platform::GetOSVersion() { return GetCachedUTSName()->release; }

char const *Platform::GetOSBuild() { return GetCachedUTSName()->version; }
char const *Platform::GetOSBuild() { return GetCachedUTSName()->release; }

char const *Platform::GetOSKernelPath() { return nullptr; }
char const *Platform::GetOSKernelVersion() { return GetCachedUTSName()->version; }

const char *Platform::GetSelfExecutablePath() {
return Host::FreeBSD::ProcStat::GetExecutablePath(getpid()).c_str();
Expand Down
Loading