implement a subset of match filters for the qfProcessInfo
and qsProcessInfo
packets
#168
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Properly implement a subset of match filters for the
qfProcessInfo
andqsProcessInfo
packets.fixes #167
fixes #171
Overview
Handle_qfProcessInfo
implementation to parse the incoming string; it was mistakenly using the full argument stringargs
instead of the individual argument stringarg
.Handle_qfProcessInfo
. It was incorrectly not decoded before.PlatformSessionImplBase::updateProcesses
to clear the process list before enumerating/matching.PlatformSessionImplBase::processMatch
to perform the actual matching against the values provided with theqfProcessInfo
packet. They were previously ignored (and noted in a TODO).ProcessInfo
structure and the base thread name for the process.ProcessInfo.name
being the fully qualified executable file name.TestProcessAttach.ProcessAttachTestCase.test_attach_to_process_by_name
test case on Linux and Android.Background
The
qfProcessInfo
andqsProcessInfo
packets are and LLDB platform extension and are used together to enumerate processes on the target. They are documented here.Validation
Ranually run the
test_attach_to_process_by_name
test case on Android and Linux to confirm it passes.