add openvr 1.9.15 #579
Closed
add openvr 1.9.15 #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some configurations of 'openvr/1.9.15' have failed:
|
|
Some configurations of 'openvr/1.9.15' have failed:
|
|
Some configurations of 'openvr/1.9.15' have failed:
|
|
Some configurations of 'openvr/1.9.15' have failed:
|
|
Some configurations of 'openvr/1.9.15' have failed:
|
|
Some configurations of 'openvr/1.9.15' have failed:
|
|
Some configurations of 'openvr/1.9.15' have failed:
|
|
Some configurations of 'openvr/1.9.15' have failed:
|
|
Some configurations of 'openvr/1.9.15' failed in build 9 (
|
|
An unexpected error happened and has been reported. Help is on its way! 🏇 |
uilianries
reviewed
Mar 5, 2020
| include("${CMAKE_BINARY_DIR}/conanbuildinfo.cmake") | ||
| conan_basic_setup() | ||
|
|
||
| set(CMAKE_CXX_STANDARD 11) |
There was a problem hiding this comment.
Why do you need it? The cmake file from author should configure it.
uilianries
requested changes
Mar 5, 2020
| topics = ("conan", "openvr", "vr", ) | ||
| url = "https://github.com/conan-io/conan-center-index" | ||
| homepage = "https://github.com/ValveSoftware/openvr" | ||
| license = "BSD 3-Clause" |
There was a problem hiding this comment.
Suggested change
| license = "BSD 3-Clause" | |
| license = "BSD-3-Clause" |
| def _configure_cmake(self): | ||
| cmake = CMake(self) | ||
| cmake.definitions["BUILD_SHARED"] = self.options.shared | ||
| cmake.definitions["USE_LIBCXX"] = self.settings.compiler != "Visual Studio" and str(self.settings.compiler.libcxx) == "libc++" |
There was a problem hiding this comment.
Suggested change
| cmake.definitions["USE_LIBCXX"] = self.settings.compiler != "Visual Studio" and str(self.settings.compiler.libcxx) == "libc++" | |
| cmake.definitions["USE_LIBCXX"] = str(self.settings.compiler.libcxx) == "libc++" |
Visual Studio doesn't use libc++
|
Some configurations of 'openvr/1.9.15' failed in build 11 (
|
|
@intelligide please address the comments above. We'd like to move this PR forward if possible. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: openvr/1.9.15
conan-center hook activated.