Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

giflib: relocatable shared lib on macOS #9072

Merged
merged 2 commits into from
Feb 1, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jan 25, 2022

see conan-io/hooks#376


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

also refactor custom CMakeLists in 5.2.x
@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 25, 2022

CMake Error at build/86b9715155a3ea9d377d41d1d937978b28e691c8/FindGIF.cmake:40 (add_library):
  Attempting to use @rpath without CMAKE_SHARED_LIBRARY_RUNTIME_C_FLAG being
  set.  This could be because you are using a Mac OS X version less than 10.5
  or because CMake's platform configuration is corrupt.
Call Stack (most recent call first):
  build/86b9715155a3ea9d377d41d1d937978b28e691c8/FindGIF.cmake:126 (conan_package_library_targets)
  CMakeLists.txt:7 (find_package)

It seems that it happens only with shared libs produced by autotools builds. => no, some CMake based recipes also have this issue.

avoid error "Attempting to use @rpath without CMAKE_SHARED_LIBRARY_RUNTIME_C_FLAG being set."
@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

All green in build 3 (359a467f98dcf9fd7326f1b3a1219370c8b5870d):

  • giflib/5.1.4@:
    All packages built successfully! (All logs)

  • giflib/5.2.1@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit c4a7e6a into conan-io:master Feb 1, 2022
@SpaceIm SpaceIm deleted the giflib-relocatable-macos branch February 1, 2022 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants