Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding hooks at the job level, rather than individual steps #166

Closed
vito opened this issue Oct 14, 2015 · 5 comments
Closed

Support adding hooks at the job level, rather than individual steps #166

vito opened this issue Oct 14, 2015 · 5 comments

Comments

@vito
Copy link
Member

vito commented Oct 14, 2015

e.g.:

name: my-job
plan:
- get: something
- task: run-something
on_failure: {...}
on_success: {...}
ensure: {...}

would be equivalent to:

name: my-job
plan:
- do:
  - get: something
  - task: run-something
  on_failure: {...}
  on_success: {...}
  ensure: {...}
@vito vito changed the title Suppoy adding hooks at the job level, rather than individual steps Support adding hooks at the job level, rather than individual steps Oct 14, 2015
@robdimsdale
Copy link
Contributor

+1

@concourse-bot
Copy link
Collaborator

Hi there!

We use Pivotal Tracker to provide visibility into what our team is working on. A story for this issue has been automatically created.

The current status is as follows:

  • #105686432 Support adding hooks at the job level, rather than individual steps

This comment, as well as the labels on the issue, will be automatically updated as the status in Tracker changes.

@bendodd
Copy link

bendodd commented Feb 21, 2016

+1

@mtekel
Copy link

mtekel commented May 9, 2016

+1. I'd like to be add ensure into do or aggregate blocks (and not directly to each task).

@mtekel
Copy link

mtekel commented May 9, 2016

As it turns out, it does what I need to do in concourse 0.76, but the interface only shows ensure block for the last task (yet it works as ensure block for whole do):

      - do:
        - task: create-temp-user
          file: paas-cf/concourse/tasks/create_admin.yml
          config:
            params:
              PREFIX: smoketest-user

        - task: smoke-tests-config
          file: paas-cf/concourse/tasks/smoke-tests-config.ymll

        - task: smoke-tests-run
          file: paas-cf/concourse/tasks/smoke-tests-run.yml
        ensure:
          task: remove-temp-user
          file: paas-cf/concourse/tasks/delete_admin.yml

renders as
image
but works as ensure for the whole do block:
image

Also, documentation mentions that you can only do ensure on a step.
EDIT: apparently this happens in 1.1 as well. Created a separate issue #434

cdutra pushed a commit that referenced this issue Aug 4, 2016
[finishes #127219723]

Submodule src/github.com/concourse/atc 1ee1c48..a3023dd:
  > ginkgo blur reoreded everything
  > return all public pipelines on GetAllPipelines endpoint
  > only check for basic auth on get token endpoint
  > do not default team name to main if not provided
  > do not default team name to main in api
Submodule src/github.com/concourse/fly cb98e4c..3269297:
  > make --team-name required
  > retrieves token if there is no auth method set
Submodule src/github.com/concourse/testflight fdd0c3f..abd306e:
  > do not default team name to 'main'
Submodule src/github.com/onsi/ginkgo e43390e..74c678d:
  > Make JUnit reporter include failure location in message. (#262)
  > remove 1.4 from travis.yml
  > Add gcflags option (#276)
  > Revert "Use the go1.5 build tag to handle vendor exceptions" (#274)
  > Merge pull request #272 from fsouza/fix-vendor
  > Add flaky test mitigation (#261)
  > Allow units and precision in benchmark (#266)
  > Add Solaris support (#264)
  > Merge pull request #259 from kwadrat/master
  > Merge branch 'apvail-spell-fix'
  > Fix go16 vendor
  > Merge pull request #250 from james-lawrence/master
  > Merge pull request #228 from jayunit100/RegexFileNameFiltering
  > Fix test flakiness
  > Merge pull request #235 from mboersma/fix-travis
  > fix compilation on older versions of go
  > fix issue where packages that reference vendored dependencies weren't compiling
  > Merge pull request #216 from sha1sum/master
  > Merge pull request #209 from luxas/build_on_arm64
  > Merge pull request #212 from cfmobile/master
  > Merge pull request #210 from cfmobile/master
Submodule src/github.com/onsi/gomega 2152b45..9ed8da1:
  > Merge pull request #166 from trayo/patch-2
  > Merge pull request #164 from wendorf/assert_typo
  > Merge remote-tracking branch 'origin/pr/163'
  > Merge pull request #160 from tinygrasshopper/fix_failing_close_ghttp
  > Merge pull request #150 from tinygrasshopper/build-fix
  > Merge pull request #159 from WesleyJeanette/patch-1
  > Merge pull request #157 from kwadrat/master
  > Merge pull request #141 from mariantalla/gomega-yaml-matcher
  > Reset tmpDir in gexec.CleanupBuildArtifacts
  > Update test description for match json tests.
  > Make the error message for expected JSON values having the wrong type accurate
  > Merge pull request #133 from tjarratt/be-identical-to-matcher
  > Merge pull request #132 from tjarratt/improve-match-json-error-message
  > Merge pull request #128 from tinygrasshopper/have-cap
  > drop 1.4 from travis
  > ghttp tests should now pass in 1.6
  > CloseClientConnections test uses http.Post instead of http.Get to avoid retries
  > add tip to .travis.yml
  > Merge pull request #125 from cfmobile/master
  > Merge pull request #122 from cfmobile/master
  > Merge pull request #119 from jim-slattery-rs/gitignore_idea
  > Merge pull request #118 from jim-slattery-rs/fix_up_succeed

Signed-off-by: Yucheng Tu <ytu@pivotal.io>
jmcarp added a commit to jmcarp/atc that referenced this issue Oct 15, 2016
topherbullock pushed a commit to vmware-archive/atc that referenced this issue Dec 19, 2016
shashwathi pushed a commit that referenced this issue Mar 29, 2018
#1880

Submodule src/github.com/concourse/fly bc1103e..f666354:
  > Error if manually enter token is invalid format
Submodule src/github.com/dgrijalva/jwt-go 63734eae..06ea1031:
  > documentation around expected key types
  > Merge branch 'master' of github.com:dgrijalva/jwt-go
  > add options to ParseFromRequest
  > fixed a formatting error in a test
  > documenting changes for upcoming 3.2.0 release
  > Merge pull request #152 from pusher/parse-unverified
  > Merge pull request #219 from geertjanvdk/feat/parse
  > Merge pull request #205 from zamicol/icon_godoc
  > Merge pull request #209 from zhyuri/patch-1
  > Merge pull request #220 from polarina/readme-alt-include
  > Notice about upcoming 4.0.0 release
  > 3.1.0 changelog
  > Merge pull request #218 from zoofood/patch-1
  > updated note on alg type vulnerability
  > Merge pull request #183 from hnakamur/support_rs256_in_jwt_command
  > Merge pull request #196 from dgrijalva/dg/cmd_args
  > Merge pull request #190 from jamesrwhite/patch-1
  > Merge pull request #180 from kevinburke/fix-unreachable
  > Merge pull request #166 from johnlockwood-wf/issue-165-missing-arg
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants