Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ambiguous example in versioning documentation #266

Closed
alidaka opened this issue Jan 25, 2016 · 2 comments
Closed

Ambiguous example in versioning documentation #266

alidaka opened this issue Jan 25, 2016 · 2 comments

Comments

@alidaka
Copy link

alidaka commented Jan 25, 2016

On this page:

https://concourse.ci/versioned-s3-artifacts.html

AKA

https://github.com/concourse/concourse/blob/master/docs/examples/versioned-s3-artifacts.yml

There is an example of wildcarding a parameter:

- put: my-product-rc
    params: {from: build-artifact/my-product-.*.tgz}

The last period before "tgz" should be escaped. This caused us some confusion when comparing against normal path parameters.

@concourse-bot
Copy link
Collaborator

Hi there!

We use Pivotal Tracker to provide visibility into what our team is working on. A story for this issue has been automatically created.

The current status is as follows:

  • #112383295 Ambiguous example in versioning documentation

This comment, as well as the labels on the issue, will be automatically updated as the status in Tracker changes.

@vito
Copy link
Member

vito commented Jan 26, 2016

fixed this in 9a4bc8c by using file instead of from, which is deprecated anyway

thanks!

@vito vito closed this as completed Jan 26, 2016
cdutra pushed a commit that referenced this issue Aug 4, 2016
[finishes #127219723]

Submodule src/github.com/concourse/atc 1ee1c48..a3023dd:
  > ginkgo blur reoreded everything
  > return all public pipelines on GetAllPipelines endpoint
  > only check for basic auth on get token endpoint
  > do not default team name to main if not provided
  > do not default team name to main in api
Submodule src/github.com/concourse/fly cb98e4c..3269297:
  > make --team-name required
  > retrieves token if there is no auth method set
Submodule src/github.com/concourse/testflight fdd0c3f..abd306e:
  > do not default team name to 'main'
Submodule src/github.com/onsi/ginkgo e43390e..74c678d:
  > Make JUnit reporter include failure location in message. (#262)
  > remove 1.4 from travis.yml
  > Add gcflags option (#276)
  > Revert "Use the go1.5 build tag to handle vendor exceptions" (#274)
  > Merge pull request #272 from fsouza/fix-vendor
  > Add flaky test mitigation (#261)
  > Allow units and precision in benchmark (#266)
  > Add Solaris support (#264)
  > Merge pull request #259 from kwadrat/master
  > Merge branch 'apvail-spell-fix'
  > Fix go16 vendor
  > Merge pull request #250 from james-lawrence/master
  > Merge pull request #228 from jayunit100/RegexFileNameFiltering
  > Fix test flakiness
  > Merge pull request #235 from mboersma/fix-travis
  > fix compilation on older versions of go
  > fix issue where packages that reference vendored dependencies weren't compiling
  > Merge pull request #216 from sha1sum/master
  > Merge pull request #209 from luxas/build_on_arm64
  > Merge pull request #212 from cfmobile/master
  > Merge pull request #210 from cfmobile/master
Submodule src/github.com/onsi/gomega 2152b45..9ed8da1:
  > Merge pull request #166 from trayo/patch-2
  > Merge pull request #164 from wendorf/assert_typo
  > Merge remote-tracking branch 'origin/pr/163'
  > Merge pull request #160 from tinygrasshopper/fix_failing_close_ghttp
  > Merge pull request #150 from tinygrasshopper/build-fix
  > Merge pull request #159 from WesleyJeanette/patch-1
  > Merge pull request #157 from kwadrat/master
  > Merge pull request #141 from mariantalla/gomega-yaml-matcher
  > Reset tmpDir in gexec.CleanupBuildArtifacts
  > Update test description for match json tests.
  > Make the error message for expected JSON values having the wrong type accurate
  > Merge pull request #133 from tjarratt/be-identical-to-matcher
  > Merge pull request #132 from tjarratt/improve-match-json-error-message
  > Merge pull request #128 from tinygrasshopper/have-cap
  > drop 1.4 from travis
  > ghttp tests should now pass in 1.6
  > CloseClientConnections test uses http.Post instead of http.Get to avoid retries
  > add tip to .travis.yml
  > Merge pull request #125 from cfmobile/master
  > Merge pull request #122 from cfmobile/master
  > Merge pull request #119 from jim-slattery-rs/gitignore_idea
  > Merge pull request #118 from jim-slattery-rs/fix_up_succeed

Signed-off-by: Yucheng Tu <ytu@pivotal.io>
jmelchio added a commit that referenced this issue Apr 19, 2018
#2109

Submodule src/github.com/concourse/atc ddabe92..4b3bab2:
  > Fix reaper server addr
  > Merge pull request #258 from govau/buildlogretention
  > Support migration options in web binary (#266)
  > Merge pull request #268 from SHyx0rmZ/release-resource-type-lock-on-error
Submodule src/github.com/concourse/tsa ae2e16e..62eb12d:
  > Use reaper client with default transport
  > Merge pull request #7 from SHyx0rmZ/call-logger-info-instead-of-session
Submodule src/github.com/concourse/worker 670e406..ac8724a:
  > Update reaper client

Signed-off-by: Shash Reddy <sreddy@pivotal.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants