re2 v2023-06-01 #66
re2 v2023-06-01 #66
Conversation
…nda-forge-pinning 2023.05.31.19.00.54
regro-cf-autotick-bot
requested review from
h-vetinari,
isuruf,
kszucs,
pitrou,
scopatz,
wesm and
xhochy
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Partially revert "bump to C++17 and increase version due to ABI change" This reverts commit 329c8ab.
upstream requires it since google/re2@552c2b8
h-vetinari
force-pushed
the
2023-06-01_h7e2d80
branch
from
0f28fb7
to
8dab91f
Compare
| # see https://github.com/google/re2/blob/2023-06-01/CMakeLists.txt#L32-L34 | ||
| # changes more rarely than version | ||
| {% set soversion = "11.0.0" %} |
There was a problem hiding this comment.
We should decide if we want to make use of this to reduce the volume of migrations, and how, see #67
|
Windows is running into conda/conda-build#4605 (well, at least it's obscuring what the actual failure is), which seems to happen at the CMake integeration test (because before 397d326, there was a pkg-config error visible, and now it's not anymore) |
h-vetinari
force-pushed
the
2023-06-01_h7e2d80
branch
2 times, most recently
from
1033768
to
004640f
Compare
h-vetinari
force-pushed
the
2023-06-01_h7e2d80
branch
2 times, most recently
from
3ef7aa5
to
a0ee4e1
Compare
used to run by default on windows, but for some reason, not anymore as of version 2023-06-01. Instead, we got: ``` (%BUILD_PREFIX%) %SRC_DIR%\cmake-build>ctest -E "dfa|exhaustive|random" Test project D:/bld/re2_1685587912468/work/cmake-build No tests were found!!! ```
h-vetinari
force-pushed
the
2023-06-01_h7e2d80
branch
from
a0ee4e1
to
22c87fb
Compare
upstream re2 already sets this for the main library, see https://github.com/google/re2/blob/2023-06-01/CMakeLists.txt#L145, but we need it to apply to the testing library as well.
|
The pcre-issue could be solved by host-depending on |
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_fileis packagedInformation about this PR:
@conda-forge-admin,please add bot automergein the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.Dependency Analysis
Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add
bot: inspection: falseto yourconda-forge.yml. If you encounter issues with this feature please ping the bot teamconda-forge/bot.Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.
Packages found by source code inspection but not in the meta.yaml:
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/5137011166, please use this URL for debugging.