re2 v2023-06-02 #68
Merged
re2 v2023-06-02 #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nda-forge-pinning 2023.06.01.15.19.33
regro-cf-autotick-bot
requested review from
h-vetinari,
isuruf,
kszucs,
pitrou,
scopatz,
wesm and
xhochy
as code owners
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Partially revert "bump to C++17 and increase version due to ABI change" This reverts commit 329c8ab.
upstream requires it since google/re2@552c2b8
used to run by default on windows, but for some reason, not anymore as of version 2023-06-01. Instead, we got: ``` (%BUILD_PREFIX%) %SRC_DIR%\cmake-build>ctest -E "dfa|exhaustive|random" Test project D:/bld/re2_1685587912468/work/cmake-build No tests were found!!! ```
h-vetinari
requested changes
Jun 2, 2023
h-vetinari
force-pushed
the
2023-06-02_h5c5cd3
branch
7 times, most recently
from
5ba6672
to
33bcff8
Compare
h-vetinari
approved these changes
Jun 12, 2023
There was a problem hiding this comment.
This should now hopefully implement the solution to #67
PTAL @conda-forge/re2
xhochy
requested changes
Jun 12, 2023
Co-authored-by: Uwe L. Korn <xhochy@users.noreply.github.com>
xhochy
approved these changes
Jun 12, 2023
h-vetinari
force-pushed
the
2023-06-02_h5c5cd3
branch
3 times, most recently
from
c07f5cf
to
f1666a3
Compare
…oversions because any new soversion (which is validated also by the pkg-config check) will then have a non-overlapping constraint for the allowed re2-version
h-vetinari
force-pushed
the
2023-06-02_h5c5cd3
branch
from
f1666a3
to
8f866ee
Compare
3 tasks
|
@conda-forge/re2, is this ready to get merged? |
|
Or do you want to go straight to one of the newer releases, perhaps? |
3 tasks
3 tasks
|
@conda-forge-admin, please rerender |
isuruf
reviewed
Oct 10, 2023
…nda-forge-pinning 2023.10.10.09.57.53
h-vetinari
force-pushed
the
2023-06-02_h5c5cd3
branch
from
633b25a
to
7cce4d6
Compare
|
Alright, I'll merge this in 24h, unless there are other comments. Thanks all for hashing this one out! |
xhochy
approved these changes
Oct 11, 2023
This was referenced Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_fileis packagedInformation about this PR:
@conda-forge-admin,please add bot automergein the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerunlabel to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase@conda-forge-admin, please rerun botin a PR comment to have theconda-forge-adminadd it for you.Closes #66
Closes #67
Dependency Analysis
Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add
bot: inspection: falseto yourconda-forge.yml. If you encounter issues with this feature please ping the bot teamconda-forge/bot.Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.
Packages found by source code inspection but not in the meta.yaml:
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/5146856599, please use this URL for debugging.