Enable xattr test for macOS

[kenodegard]

Description

Xattr test previously only ran on Linux (if setfattr is present), made necessary changes to allow the test to also run on macOS.

Updated testing_homedir fixture to use a simpler tempfile.TemporaryDirectory implementation.

Checklist - did you ...

• Add a file to the news directory (using the template) for the next release's release notes?
• Add / update necessary tests?
• Add / update outdated documentation?

[travishathaway]

Deprecated since version 3.9: collections.abc.Generator now supports subscripting ([]). See PEP 585 and Generic Alias Type (source: https://docs.python.org/3/library/typing.html?highlight=typing#typing.Generator)

You can also just use Iterator too if you don't need to specify the extra types in a Generator:

from collections.abc import Iterator

def oh_it_iterates() -> Iterator[str]:
    yield "iter"
    yield "ator"
    yield "!!!"

[kenodegard]

Oh cool! I didn't know this!

[kenodegard]

Hm, since this was a change introduced in Python 3.9 we'd have to do a try-except to use the updated subscriptable types. So I think we should wait until we drop Python 3.8 support before making the switch from typing to collections.abc.

[travishathaway]

Looks good. I just want to make sure we are not using any of the deprecated types in the typing module.

[sven6002]

Looks good to me

stale review