Update pylint from 2.3.1 to 2.7.4
#5153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the last `pylint` to use `setup.py` without `setup.cfg`
conda-bot
added
the
cla-signed
beeankha
approved these changes
Jan 26, 2024
jezdez
approved these changes
Jan 26, 2024
mbargull
reviewed
Jan 26, 2024
| @@ -297,7 +314,7 @@ def test_get_package_metadata(testing_config, mock_metadata, pylint_metadata): | |||
| mock_metadata, | |||
| {}, | |||
| ".", | |||
| "3.7", | |||
There was a problem hiding this comment.
This is probably the thing that fixed the CI.
Python >=3.8 handles TemporaryDirectory cleanups better: python/cpython#10320 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
tests/test_api_skeleton.py::test_get_package_metadatahas suddenly become very flaky on Windows (not sure why, it almost looks like a caching issue or some other Windows specific issue where its unable to properly delete old files), see recent failures here and here.This is a dumb attempt to fix the issue by simply updating the
pylintversion (from 2.3.1 to 2.7.4, the lastpylintto usesetup.pywithoutsetup.cfg) the test fetches from PyPI. As a bonus this change also allows the test to succeed onosx-arm64.Checklist - did you ...
Add a file to thenewsdirectory (using the template) for the next release's release notes?Add / update outdated documentation?