-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix extraneous output when outputting build path #950
Conversation
Now I see the "old" (and wrong) behavior again, i.e. it reports a label that doesn't correspond to what's in my local tree. |
Yeah, I was trying to be clever about avoiding downloading the source, but that just doesn't work. It will successfully render without it in your case, but it will not be accurate. |
7dca28c
to
1b89c42
Compare
Now
|
Current coverage is 13.0%@@ master #950 diff @@
==========================================
Files 42 42
Lines 5305 5313 +8
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 632 691 +59
+ Misses 4673 4622 -51
Partials 0 0
|
Can you quickly clarify when the source is downloaded now? To me, it looks like it is downloaded always, regardless of if it is needed or not. This would be a huge problem for bioconda, because we use --skip-existing and --output to determine if recipes need a rebuild. However, we have thousands of recipes in our repository and downloading the source for all of them would need ages. |
This isn't finished yet. The idea is that it will only download source when it needs to. For example, if your recipe uses git variables in jinja templates, you can't know the build output path without downloading the source. However, if that's not necessary, then we should not download the source. |
That's good, thanks! |
bae13e2
to
faf292b
Compare
if src_path.lower().endswith(('.tar.gz', '.tar.bz2', '.tgz', '.tar.xz', | ||
'.tar', 'tar.z')): | ||
tar_xf(src_path, WORK_DIR) | ||
elif src_path.lower().endswith('.zip'): | ||
unzip(src_path, WORK_DIR) | ||
else: | ||
# In this case, the build script will need to deal with unpacking the source | ||
print("Warning: Unrecognized source format. Source file will be copied to the SRC_DIR") | ||
if verbose: | ||
print("Warning: Unrecognized source format. Source file will be copied to the SRC_DIR") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this warning be raised even if verbose
is False
? I normally think of verbose as "no chatter, but if something goes wrong please do tell me."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'll fix that.
Just one fairly minor comment. The tests do seem to be checking for #949 properly. Haven't tried running this locally, but can if you want. |
f971512
to
560efbb
Compare
560efbb
to
46b44ba
Compare
conda build --output was outputting other stuff, when external tools required strictly the package output path. This fixes it, and adds tests for the behavior.
Closes #949 (sorry everyone)