Fix for duplicate acls #1370
Merged
Fix for duplicate acls #1370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhowlett
reviewed
Jun 14, 2022
mhowlett
reviewed
Jun 14, 2022
|
I removed the previous dummy change from the RC branch, please make sure it won't be merged again. |
or ACL binding filters are passed.
emasab
force-pushed
the
bugfix/documentation-and-duplicated-acls
branch
from
43cc5b5 to
076e282
Compare
mhowlett
reviewed
Jun 14, 2022
examples/adminapi.py
Outdated
| print(f"Invalid input: {e}") | ||
| return | ||
|
|
||
| if fs is None: |
There was a problem hiding this comment.
is this possible? I don't reckon, no need to check.
edenhill
suggested changes
Jun 15, 2022
|
There are also some test failures due to trivup not starting, see if the a new run (after fixing the other issues) solves it. |
edenhill
suggested changes
Jun 15, 2022
emasab
force-pushed
the
bugfix/documentation-and-duplicated-acls
branch
from
f7dd6f7 to
5d35089
Compare
jairhenrique
pushed a commit
to jairhenrique/confluent-kafka-python
that referenced
this pull request
Jun 21, 2022
raised ValueError if duplicate ACL bindings or ACL binding filters are passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In create_acls and delete_acls it returns a dict with AclBinding or AclBindingFilters as keys.
If sent parameters are not unique the returned dict has less entries than the sent ones and it causes and Exception.