feat(taxonomy): add getConceptAncestors and getConceptDescendants functions [] #2565
Conversation
lib/types/client.ts
Outdated
| getConceptAncestors( | ||
| id: string, | ||
| query?: ConceptAncestorsDescendantsQueries, | ||
| ): Promise<ConceptCollection<'en-US'>> |
There was a problem hiding this comment.
non-blocking question: why hard-code to en-US, I can see that other taxonomy methods also return a en-US type, but is there some more context? Are all taxonomy features hard-coded to en-US at the moment?
There was a problem hiding this comment.
Good question -- when Taxonomy started only en-US was available, but nowadays customers can actually get their concepts in different languages.
For these new methods it might be useful to use Locale code instead here. Good point.
|
@ethan-ozelius-contentful sorry for the ping again -- the endpoints are now available and I also updated the tests. Would appreciate the review again 🙇🏽 |
|
🎉 This PR is included in version 11.8.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
client.getConceptAncestors('conceptId', { depth: 2})client.getConceptDescendants('conceptId', { depth: 5 })Description
Motivation and Context
Todos
Screenshots (if appropriate):