Development #182
Merged
Development #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
reeshika-h
commented
Sep 10, 2025
reeshika-h
commented
- added oauth implementation and unit testcases
back merge
- Add TokenCallback interface for token storage events - Update OAuthConfig to include tokenCallback - Update OAuthHandler to use callback for token events
Feat : Oauth implementation
|
We regret to inform you that you are currently not able to merge your changes into the master branch due to restrictions applied by our SRE team. To proceed with merging your changes, we kindly request that you create a pull request from the staging branch. Our team will then review the changes and work with you to ensure a successful merge into the master branch. |
…support - Removed deprecated setOAuthWithPKCE methods and consolidated OAuth configuration into a single setOAuth method. - Updated documentation to clarify clientSecret usage for PKCE flow. - Adjusted error message for missing OAuth configuration to reflect new method usage.
…upport for optional client secret - Simplified setOAuth methods by removing the clientSecret parameter from the primary overloads. - Added a new setOAuth method to accommodate an optional client secret while maintaining PKCE flow. - Updated documentation to reflect changes in method signatures and clarify the use of client secret.
Fix oauth implementation
harshithad0703
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.