Skip to content

[UI/UX] some random small enhancements 💅 #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2023
Merged

[UI/UX] some random small enhancements 💅 #679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/admin/user.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@
end
column :entry_date
column :member_uid
column :tag_list
end
end
end
Expand Down
10 changes: 7 additions & 3 deletions app/assets/stylesheets/application.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@ html {
}

.content {
margin-bottom: 76px;
margin-bottom: 120px;
}

.actions-menu {
margin-bottom: 16px;
padding: 0 15px;
margin-bottom: 10px;
padding: 0 10px;

@media(max-width: $screen-sm-min) {
padding: 0;
Expand Down Expand Up @@ -670,6 +670,10 @@ label[required]::after{
margin: 0 !important;
}

.organization-logo {
padding-top: 120px;
}

.input__password-eye {
display: flex;
align-items: center;
Expand Down
7 changes: 0 additions & 7 deletions app/assets/stylesheets/application/member-card.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,6 @@
}
}

&__tags {
a {
margin-left: 4px;
color: white;
}
}

&__activity {
font-size: 14px;
color: #78adb9;
Expand Down
2 changes: 1 addition & 1 deletion app/helpers/application_helper.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def organization_logo
return unless org && org.logo.attached?
return if "#{controller_name}##{action_name}".in? %w(organizations#index pages#show)

content_tag(:div, class: "row") do
content_tag(:div, class: "row organization-logo") do
image_tag(org.logo.variant(resize: "x200^"), class: 'img-responsive center-block')
end
end
Expand Down
6 changes: 0 additions & 6 deletions app/views/inquiries/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
<div class="container-fluid">
<div class="row">
<div class="col-md-12">
<h1>
Expand All @@ -7,9 +6,7 @@
</h1>
</div>
</div>
</div>

<div class="container-fluid">
<div class="row">
<%= render "shared/post_filters", base_path: inquiries_path %>

Expand All @@ -26,14 +23,11 @@
<% end %>
</div>
</div>
</div>

<div class="container-fluid inquiries">
<div class="row">
<div class="col-md-12">
<%= render "shared/posts", posts: @inquiries %>
</div>
</div>
</div>

<%= paginate @inquiries %>
4 changes: 2 additions & 2 deletions app/views/inquiries/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<% if @inquiry.organization == current_organization %>
<p class="actions text-right">
<div class="actions text-right">
<% if admin? or @inquiry.user == current_user %>
<%= render 'shared/post_actions', post: @inquiry %>
<% end %>
</p>
</div>
<% end %>
<%= render "shared/post", post: @inquiry %>
2 changes: 2 additions & 0 deletions app/views/layouts/application.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@
<%= render 'navbar' %>
<div class="container content">
<%= render 'layouts/messages' unless devise_controller? %>
<div class="container-fluid">
<%= yield %>
</div>
<%= organization_logo %>
</div>
<div class="modal fade" id="modal">
Expand Down
2 changes: 0 additions & 2 deletions app/views/multi_transfers/step.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,10 @@
<% end %>

<div class="form-group">
<div class="container">
<div class="row">
<div class="col-md-2 col-md-offset-10">
<button class="btn btn-primary btn-lg"><%= @is_last_step ? t('global.create') : t('global.next') %></button>
</div>
</div>
</div>
</div>
<% end %>
6 changes: 0 additions & 6 deletions app/views/offers/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
<div class="container-fluid">
<div class="row">
<div class="col-md-12">
<h1>
Expand All @@ -7,9 +6,7 @@
</h1>
</div>
</div>
</div>

<div class="container-fluid">
<div class="row">
<%= render "shared/post_filters", base_path: offers_path %>

Expand All @@ -26,14 +23,11 @@
<% end %>
</div>
</div>
</div>

<div class="container-fluid offers">
<div class="row">
<div class="col-md-12">
<%= render "shared/posts", posts: @offers %>
</div>
</div>
</div>

<%= paginate @offers %>
4 changes: 2 additions & 2 deletions app/views/offers/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<% if @offer.organization == current_organization %>
<p class="actions text-right">
<div class="actions text-right">
<% if admin? or @offer.user == current_user %>
<%= render 'shared/post_actions', post: @offer %>
<% end %>
Expand All @@ -10,6 +10,6 @@
<%= t ".give_time_for" %>
<% end %>
<% end %>
</p>
</div>
<% end %>
<%= render "shared/post", post: @offer %>
4 changes: 0 additions & 4 deletions app/views/petitions/manage.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,8 @@
<div class="container-fluid">
<div class="row">
<div class="col-md-12">
<h1><%= t('petitions.applications') %></h1>
</div>
</div>
</div>

<div class="row">
<div class="col-xs-12 col-sm-12 col-md-12 col-lg-12">
Expand All @@ -31,7 +29,6 @@
</div>
</div>

<div class="container-fluid">
<div class="row">
<div class="col-md-12">
<div class="table-responsive">
Expand Down Expand Up @@ -76,4 +73,3 @@
</div>
</div>
</div>
</div>
2 changes: 1 addition & 1 deletion app/views/shared/_post.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<p></p>
<% if post.tags.present? %>
<% post.tags.each do |tag| %>
<span class="badge alert-success">
<span class="badge alert-info">
<%= glyph(:tag) %>
<%= link_to [post.class, tag: tag] do %>
<%= tag %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/shared/_post_actions.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<%= link_to [:edit, post], class: "btn btn-warning" do %>
<%= link_to [:edit, post], class: "btn btn-default" do %>
<%= glyph :pencil %>
<%= t "global.edit" %>
<% end %>
Expand Down
2 changes: 1 addition & 1 deletion app/views/shared/_post_form.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,5 +41,5 @@
required: true %>
</div>
<% end %>
<%= f.button label_button, class: "btn btn-default", style: "margin-bottom: 20px;" %>
<%= f.button label_button, class: "btn btn-default" %>
<% end %>
2 changes: 2 additions & 0 deletions app/views/shared/_posts.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,12 @@
</span>
<% end %>
<% (post.tags || []).each do |tag| %>
<span class="badge alert-info">
<%= glyph :tag %>
<%= link_to [post.class, tag: tag] do %>
<%= tag %>
<% end %>
</span>
<% end %>
</small>
</p>
Expand Down
10 changes: 2 additions & 8 deletions app/views/terms/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,7 @@
<header class="page-header">
<h1>
<%= @document.title %>
</h1>
<h1><%= @document.title %></h1>
</header>

<%= m @document.content %>

<%= form_tag accept_terms_path, method: :post do %>
<button class="btn" type="submit">
<%= t '.accept' %>
</button>
<% end %>
<%= button_to t('.accept'), accept_terms_path, class: "btn btn-primary" %>
2 changes: 1 addition & 1 deletion app/views/users/_member_card.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<%= t('.no_activity') %>
<% end %>
<% member.tags[0..2].each do |tag| %>
<span class="to-member-card__header__text__tags">
<span class="badge alert-info">
<%= link_to users_path tag: tag do %>
<%= glyph :tag %>
<%= tag&.truncate(29) %>
Expand Down
8 changes: 1 addition & 7 deletions app/views/users/index.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
<div class="container-fluid">
<div class="row">
<div class="col-md-12">
<h1>
Expand All @@ -7,24 +6,20 @@
</h1>
</div>
</div>
</div>

<div class="container-fluid">
<div class="row">
<div class="col-md-12">
<%= search_form_for(@search, class: "navbar-form navbar-left", url: users_path) do |f| %>
<div class="form-group">
<%= f.search_field :member_search_cont, class: "form-control" %>
<%= f.search_field :member_search_cont, value: params.dig(:q, :member_search_cont), class: "form-control" %>
</div>
<button class="btn btn-default" type="submit">
<%= t 'global.search' %>
</button>
<% end %>
</div>
</div>
</div>

<div class="container-fluid">
<div class="row to-member-cards">
<%= render partial: 'member_card', collection: @member_view_models, as: :member %>
</div>
Expand All @@ -34,4 +29,3 @@
<%= paginate @members %>
</div>
</div>
</div>
9 changes: 1 addition & 8 deletions app/views/users/manage.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
<div class="container-fluid">
<div class="row">
<div class="col-md-12">
<h1>
Expand All @@ -7,14 +6,12 @@
</h1>
</div>
</div>
</div>

<div class="container-fluid">
<div class="row">
<div class="col-md-12">
<%= search_form_for(@search, class: "navbar-form navbar-left", url: manage_users_path) do |f| %>
<div class="form-group">
<%= f.search_field :member_search_cont, class: "form-control" %>
<%= f.search_field :member_search_cont, value: params.dig(:q, :member_search_cont), class: "form-control" %>
</div>
<button class="btn btn-default" type="submit">
<%= t 'global.search' %>
Expand All @@ -32,10 +29,7 @@
</ul>
</div>
</div>
</div>
<br>

<div class="container-fluid">
<div class="row">
<div class="col-md-12">
<div class="table-responsive">
Expand Down Expand Up @@ -75,4 +69,3 @@
</div>
</div>
</div>
</div>
2 changes: 1 addition & 1 deletion app/views/users/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
</dt>
<dd>
<% @member.tags.each do |tag| %>
<span class="badge alert-success">
<span class="badge alert-info">
<%= link_to users_path tag: tag do %>
<%= glyph(:tag) %>
<%= tag %>
Expand Down