Skip to content

services/events #15

Closed
bradmontgomery opened this Issue Jun 16, 2012 · 8 comments

4 participants

@bradmontgomery

Greetings!

Is anyone doing any work to support the events api? If not, I'm interested in working on it.

@copitux
Owner
copitux commented Jun 16, 2012

I don't think so, it'd be wonderful if you could help ;)

@dialelo
dialelo commented Jul 5, 2012

Hi @bradmontgomery, how is the Event API implementation going so far? Let me know if I could give you a hand with this.

@bradmontgomery

@alejandrogomez Sorry for the late reply, but I haven't gotten very far yet. In fact, I haven't even pushed anything to my fork, but here's the general idea that I had for this:

  1. Build an pygithub3.services.events package modeled after the other services.
  2. Within that, build an Events with attributes corresponding to the various events available.
  3. Proxy Issues and Repo events to the existing implementation for those services.

I haven't looked too closely at the Repo events implementation so I'm not sure if it's complete.

I'll try to push my progress out later today, and you're welcome to jump in and lead the work! If you've already done some work on this, I'd love to check it out and see if we can merge anything.

@toutouastro

@bradmontgomery You can just start with some code and I will help!

@bradmontgomery

For those interested, my initial work is here: bradmontgomery/python-github3@edff0e8

Feel free to jump in. Feedback is welcome!

I won't have a chance to do much over the next two days, but following that I hope to spend a lot of time on this.

@dialelo
dialelo commented Jul 8, 2012

@bradmontgomery cool, I'm not going to be able to review it for the next two days but I will take a look on tuesday.

@toutouastro

@bradmontgomery I'll check that later :D

@bradmontgomery bradmontgomery referenced this issue Jul 24, 2012
Closed

Develop #20

@copitux
Owner
copitux commented Sep 20, 2012

merged #20

@copitux copitux closed this Sep 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.