Fix statement of Rmult_gt_reg_l in RIneq.v #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Indeed, looks like nothing is broken. Please add an entry to https://github.com/rocq-prover/stdlib/tree/master/doc/changelog#when-to-add-an-entry just in case a non-CI user was using this broken lemma, telling them what to do instead. Thanks! |
proux01
force-pushed
the
fix-rmult-gt-reg-l
branch
from
19a1584 to
c59d9b5
Compare
Contributor
|
IIRC, lt and gt are convertible, so this is almost a change of variable order between r1 and r2. Added a changelog entry just in case and let's merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes / closes #212
I don't expect this fix to break anything.