Misc small bugfixes #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix admin user index link not directing to user edit page - Fix user profile inventory display showing items with a count of 0
Draginraptor
approved these changes
Nov 28, 2020
| $approveSum = 0; | ||
| foreach($r->voteData as $voter=>$vote) { | ||
| if($vote == 1) $rejectSum += 1; | ||
| if($vote == 2) $approveSum += 1; |
There was a problem hiding this comment.
You could use increment (++$var or $var++) for these :>
There was a problem hiding this comment.
Could, but given it works and it's just fixing the fact that it was being displayed when it shouldn't have been, I'm (shrugs) about it
Comment still appreciated though!
itinerare
added
reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing misc small issues as reported by folks/the bug report channel. No specific actions needed.