Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Laravel version to 8.0 #61

Merged
merged 5 commits into from
Dec 20, 2020
Merged

Conversation

corowne
Copy link
Owner

@corowne corowne commented Dec 19, 2020

Laravel version update

  • Packages updated
  • Exceptions in Handler.php changed to Throwable
  • String and array helpers updated to use Str and Arr in laravel/helpers
  • Email verification resending link updated to use post method
  • Changes to AppServiceProvider to continue using Bootstrap

Bug fixes

  • Gallery currency queue page errors if no currencies exist
  • Missing code in CharacterManager.php

- Packages updated
- Exceptions in Handler.php changed to Throwable
- String and array helpers updated to use Str and Arr in laravel/helpers
- Email verification resending link updated to use post method
- Changes to AppServiceProvider to continue using Bootstrap
- Gallery currency queue page errors if no currencies exist
- Missing code in CharacterManager.php
Copy link
Collaborator

@itinerare itinerare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good-- only thing is possibly allowing doctrine/dbal to update, but I leave that at your discretion given the particulars of getting packages to cooperate with each other

composer.json Outdated
@@ -8,32 +8,34 @@
],
"license": "MIT",
"require": {
"php": "^7.1.3",
"php": "^7.3",
"boxconnect/deviant-php": "dev-master",
"doctrine/dbal": "2.10.4",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can I think safely be allowed to upgrade at this point, given that the issue was newer versions requiring php 7.2

@itinerare itinerare added this to the v2.0.0 milestone Dec 19, 2020
@itinerare itinerare mentioned this pull request Dec 19, 2020
28 tasks
@preimpression
Copy link
Contributor

Will the new Throwable need to be used for every instance of Exception currently used, across Extensions etc?

@itinerare itinerare added the reviewed Pull requests that have received community review and are pending merge label Dec 20, 2020
@itinerare itinerare merged commit 5377bba into develop Dec 20, 2020
@itinerare itinerare deleted the feature/update-laravel-version branch December 20, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reviewed Pull requests that have received community review and are pending merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants