-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: use an array of strings as authors in proposal metadata #14472
Conversation
This makes sense, but now we have 0.46 and 0.47 have different recommended metadata schema. Maybe we should add a line mentioning that the recommendation was a simple string for 0.46. |
We prob need to update the draft-proposal command for group and gov too to support that. But it could be done a follow-up. |
Let's do the Changes in a follow up. Happy to submit a pr later today |
(cherry picked from commit 11f46a0) # Conflicts: # CHANGELOG.md
I did not know about 0.47 having a new metadata schema. Is there a link to it? |
The new one is the one you've just made by changing the authors field :) |
Description
It makes more sense if the
authors
field in the proposal metadata is an array of strings instead of single string (since a proposal can have more than one authors).Discussion on twitter: https://twitter.com/hxrts/status/1608373720996880387
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
in the type prefix if API or client breaking change