fix: wrong address set in EventUpdateGroupPolicy
#14526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
approved these changes
Jan 7, 2023
julienrbrt
added
backport/0.46.x
mergify bot
pushed a commit
that referenced
this pull request
Jan 7, 2023
(cherry picked from commit 3729243) # Conflicts: # CHANGELOG.md
|
[Cosmos SDK] Kudos, SonarCloud Quality Gate passed!
|
mergify bot
pushed a commit
that referenced
this pull request
Jan 7, 2023
(cherry picked from commit 3729243) # Conflicts: # CHANGELOG.md # x/group/keeper/keeper_test.go
julienrbrt
commented
Jan 7, 2023
| @@ -216,6 +216,7 @@ extension interfaces. `module.Manager.Modules` is now of type `map[string]interf | |||
|
|
|||
| ### Bug Fixes | |||
|
|
|||
| * (x/group) [#](https://github.com/cosmos/cosmos-sdk/pull) Fix wrong address set in `EventUpdateGroupPolicy`. | |||
There was a problem hiding this comment.
missed the pr number here 🙈, it's not too bad, as it gets removed from here as soon we tag a final v0.47 or a v0.46.8.
julienrbrt
added a commit
that referenced
this pull request
Jan 7, 2023
…14528) Co-authored-by: Julien Robert <julien@rbrt.fr>
julienrbrt
added a commit
that referenced
this pull request
Jan 7, 2023
…14527) Co-authored-by: Julien Robert <julien@rbrt.fr>
jiujiteiro
pushed a commit
to realiotech/cosmos-sdk
that referenced
this pull request
Mar 7, 2023
…4526) (cosmos#14528) Co-authored-by: Julien Robert <julien@rbrt.fr>
JeancarloBarrios
pushed a commit
to agoric-labs/cosmos-sdk
that referenced
this pull request
Sep 28, 2024
…4526) (cosmos#14528) Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #14485
Noticed that we don't actually don't test events in group. I've just added a check on some others tests.
I did not do it everywhere because one annoying thing is that the tests use the same context.
When we remove the suite, we should check the events properly too.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!to the type prefix if API or client breaking changeCHANGELOG.mdReviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!in the type prefix if API or client breaking change