Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(distribution)!: use collections for DelegatorWithdrawAddress state management. #16440

Merged
merged 6 commits into from
Jun 8, 2023
Merged

refactor(distribution)!: use collections for DelegatorWithdrawAddress state management. #16440

merged 6 commits into from
Jun 8, 2023

Conversation

testinginprod
Copy link
Contributor

Description

Closes: #16438

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@testinginprod testinginprod marked this pull request as ready for review June 7, 2023 14:13
@testinginprod testinginprod requested a review from a team as a code owner June 7, 2023 14:13
tac0turtle
tac0turtle approved these changes Jun 8, 2023
View reviewed changes
Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some linting issue but otherwise looks good

unknown unknown added 2 commits June 8, 2023 12:03
@testinginprod testinginprod added this pull request to the merge queue Jun 8, 2023
Merged via the queue into main with commit 5235593 Jun 8, 2023
@testinginprod testinginprod deleted the tip/distribution/coll_withdraw_address branch June 8, 2023 10:20
@julienrbrt
Copy link
Member

julienrbrt commented Jun 8, 2023 •
edited
Loading

Should this get backported to 0.50?

@tac0turtle
Copy link
Member

we should backport the underflow fix yes

@julienrbrt
Copy link
Member

julienrbrt commented Jun 8, 2023 •
edited
Loading

Okay, this PR has as well a changelog at the wrong place it should be under [Unreleased] for both here and the backported PR then.

@julienrbrt julienrbrt mentioned this pull request Jun 8, 2023
Merged
19 tasks
@julienrbrt
Copy link
Member

We should cherry-pick this to v0.50 with the collections codec changes that are needed in this backport: #16853

@julienrbrt
Copy link
Member

@Mergifyio backport release/v0.50.x

@mergify
Copy link
Contributor

mergify bot commented Jul 6, 2023 •
edited
Loading

backport release/v0.50.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 6, 2023
@testinginprod @mergify
refactor(distribution)!: use collections for DelegatorWithdrawAddress…
f0751e1 
… state management. (#16440)

Co-authored-by: unknown unknown <unknown@unknown>
(cherry picked from commit 5235593)

# Conflicts:
#	CHANGELOG.md
@mergify mergify bot mentioned this pull request Jul 6, 2023
Merged
julienrbrt added a commit that referenced this pull request Jul 6, 2023
@mergify @testinginprod @julienrbrt
refactor(types)!: cherry-pick sdk collections key changes from #16440 (…
981c294 
…#16854)

Co-authored-by: testinginprod <98415576+testinginprod@users.noreply.github.com>
Co-authored-by: Julien Robert <julien@rbrt.fr>
@coderabbitai coderabbitai bot mentioned this pull request Apr 22, 2024
Merged
12 tasks
@faddat faddat mentioned this pull request Nov 8, 2024
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tac0turtle tac0turtle tac0turtle approved these changes

@kocubinski kocubinski Awaiting requested review from kocubinski

@JeancarloBarrios JeancarloBarrios Awaiting requested review from JeancarloBarrios

Assignees

@tac0turtle tac0turtle

@samricotta samricotta

Labels
C:Simulations C:x/bank C:x/distribution distribution module related C:x/gov
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor(distribution): use collections for DelegatorWithdrawAddress state management.
4 participants
@testinginprod @julienrbrt @tac0turtle @samricotta