Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update TokenizeShares operation in staking simulation #19056

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

sainoe
Copy link
Contributor

@sainoe sainoe commented Jan 15, 2024

Description

Fix computations in the TokenizeShares operations making the staking-simulation tests pass again.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@sainoe sainoe requested a review from a team as a code owner January 15, 2024 06:59
@sainoe sainoe requested a review from mpoke January 15, 2024 06:59
Copy link

@mpoke mpoke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexanderbez alexanderbez merged commit b928a7b into feature/v0.47.x-ics-lsm Jan 15, 2024
24 of 26 checks passed
@alexanderbez alexanderbez deleted the sainoe/fix-sim-lsm branch January 15, 2024 18:14
JayT106 pushed a commit to JayT106/cosmos-sdk that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🥳 Done
Development

Successfully merging this pull request may close these issues.

3 participants