Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare v50.x-lsm branch (port lsm module changes to cosmos-sdk v50) #2925

Closed
Tracked by #2871 ...
MSalopek opened this issue Feb 6, 2024 · 7 comments
Closed
Tracked by #2871 ...
Assignees
Labels
dependencies Pull requests that update a dependency file S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates) type: tech-debt Slows down development in the long run

Comments

@MSalopek
Copy link
Contributor

MSalopek commented Feb 6, 2024

LSM features need to be available for cosmos-sdk@v50.x.

Similarly to previous versions, we need to port LSM features by modifying the x/staking module.

Context:

Referencing v47 port

Reference the v47 port to learn how to perform the same steps for v50. The behaviour should remain the same and behaviour/interface changes present in cosmos-sdk@v50 should be accomodated. It is important that the LSM port does not break any x/staking functionality that should not be changed.

These are all LSM backport PRs & bugfixes that were required for v47:

@MSalopek MSalopek added dependencies Pull requests that update a dependency file type: tech-debt Slows down development in the long run S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates) labels Feb 6, 2024
@MSalopek MSalopek changed the title Figure out LSM upgrade Prepare v50.x-lsm branch (port lsm module changes to cosmos-sdk v50) Feb 6, 2024
@okwme
Copy link
Contributor

okwme commented Mar 12, 2024

Hi is this the issue I should follow for release updates that include: cosmos/cosmos-sdk#19614 ?

@mpoke
Copy link
Contributor

mpoke commented Mar 12, 2024

Hi is this the issue I should follow for release updates that include: cosmos/cosmos-sdk#19614 ?

@okwme This issue is about Gaia with SDK 0.50. The fix you're mentioning (cosmos/cosmos-sdk#19614) will be released in the next version of Gaia (v16).

@okwme
Copy link
Contributor

okwme commented Mar 12, 2024

oh wow already released and passing votes!! thank you @mpoke and the rest of the gaia squad, looking forward to the release :: )

@mpoke
Copy link
Contributor

mpoke commented Mar 12, 2024

oh wow already released and passing votes!! thank you @mpoke and the rest of the gaia squad, looking forward to the release :: )

@okwme Just to make sure we are on the same page: The Gaia version currently in voting is v15 -- https://www.mintscan.io/cosmos/proposals/885. We plan to cut an RC for Gaia v16 by end of the month. So it will get on the Hub sometimes in April.

@okwme
Copy link
Contributor

okwme commented Mar 12, 2024

oof i totally misread 16 for 15. anyway great to hear 16 is on the way and keep up the good work everyone!

@MSalopek
Copy link
Contributor Author

@MSalopek
Copy link
Contributor Author

Closing as completed with creation of cosmos-sdk v0.50.8-lsm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file S: KTLO Keeping the lights on: Keeping the current product operational (bugs, troubleshooting, deps updates) type: tech-debt Slows down development in the long run
Projects
Status: ✅ Done
Development

No branches or pull requests

5 participants