Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced hardcoded 'cosmos' and 'cosmosvaloper' help references #7056

Merged
merged 4 commits into from
Aug 17, 2020

Conversation

njmurarka
Copy link
Contributor

@njmurarka njmurarka commented Aug 14, 2020

Description

closes: #7055


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@njmurarka
Copy link
Contributor Author

My first PR here. Apologies in advance if I missed some steps.

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #7056 into master will decrease coverage by 0.01%.
The diff coverage is 36.36%.

@@            Coverage Diff             @@
##           master    #7056      +/-   ##
==========================================
- Coverage   54.72%   54.70%   -0.02%     
==========================================
  Files         539      539              
  Lines       36770    36794      +24     
==========================================
+ Hits        20121    20129       +8     
- Misses      15008    15024      +16     
  Partials     1641     1641              

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@tac0turtle tac0turtle added A:automerge Automatically merge PR once all prerequisites pass. T: Client UX T: Dev UX UX for SDK developers (i.e. how to call our code) labels Aug 15, 2020
Copy link
Collaborator

@anilcse anilcse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@alexanderbez
Copy link
Contributor

Please fix the linting issue and this should get automatically merged :)

@alessio
Copy link
Contributor

alessio commented Aug 16, 2020

@njmurarka please run make format

@njmurarka
Copy link
Contributor Author

@njmurarka please run make format

Done!

@mergify mergify bot merged commit 2079576 into cosmos:master Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. T: Client UX T: Dev UX UX for SDK developers (i.e. how to call our code)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli validator-outstanding-rewards help is showing wrong address prefix
5 participants