Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

types: update account pubkey JSON to string #494

Merged
merged 9 commits into from
Sep 7, 2020
Merged

Conversation

fedekunze
Copy link
Contributor

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@fedekunze fedekunze requested a review from noot as a code owner September 1, 2020 21:31
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

❗ No coverage uploaded for pull request base (development@820bf0f). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##             development     #494   +/-   ##
==============================================
  Coverage               ?   71.72%           
==============================================
  Files                  ?       40           
  Lines                  ?     2677           
  Branches               ?        0           
==============================================
  Hits                   ?     1920           
  Misses                 ?      616           
  Partials               ?      141           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 820bf0f...7dce82d. Read the comment docs.

app/ethermint.go Outdated Show resolved Hide resolved
@fedekunze
Copy link
Contributor Author

no clue why are the rpc tests failing

@fedekunze fedekunze added this to the v0.2.0 milestone Sep 3, 2020
noot and others added 2 commits September 7, 2020 09:45
* use Compress and Decompress pubkey for secp256k1 keys

* cleanup

* update estimate gas test
@fedekunze fedekunze merged commit d3529dd into development Sep 7, 2020
@fedekunze fedekunze deleted the account-pretty branch September 7, 2020 13:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants