Skip to content

fix: CometBlockResultByNumber when height is 0 #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 29, 2025
Merged

fix: CometBlockResultByNumber when height is 0 #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a58cf17
fix TendermintBlockResultByNumber when height is 0
Pitasi Aug 8, 2025
1ef5e69
add changelog entry
Pitasi Aug 25, 2025
da51a8b
Merge branch 'main' into fix-tendermint-block-result-by-number
aljo242 Aug 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
- [\#492](https://github.com/cosmos/evm/pull/492) Duplicate case switch to avoid empty execution block
- [\#509](https://github.com/cosmos/evm/pull/509) Allow value with slashes when query token_pairs
- [\#495](https://github.com/cosmos/evm/pull/495) Allow immediate SIGINT interrupt when mempool is not empty
- [\#416](https://github.com/cosmos/evm/pull/416) Fix regression in CometBlockResultByNumber when height is 0 to use the latest block. This fixes eth_getFilterLogs RPC.
- [\#545](https://github.com/cosmos/evm/pull/545) Check if mempool is not nil before accepting nonce gap error tx.

### IMPROVEMENTS
Expand Down
3 changes: 3 additions & 0 deletions rpc/backend/blocks.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,9 @@ func (b *Backend) CometHeaderByNumber(blockNum rpctypes.BlockNumber) (*cmtrpctyp
// CometBlockResultByNumber returns a CometBFT-formatted block result
// by block number
func (b *Backend) CometBlockResultByNumber(height *int64) (*cmtrpctypes.ResultBlockResults, error) {
if height != nil && *height == 0 {
height = nil
}
res, err := b.RPCClient.BlockResults(b.Ctx, height)
if err != nil {
return nil, fmt.Errorf("failed to fetch block result from CometBFT %d: %w", *height, err)
Expand Down
Loading