Skip to content

Conversation

Pitasi
Copy link
Contributor

@Pitasi Pitasi commented Sep 23, 2025

Description

  • I enabled hardhat optimizations to reduce the code size (after my small change to IStaking, some tests contracts were exceeding the maximum allowed)
  • Changed StakingI.sol to return the already existing Description struct instead of a string
  • Recompiled all the contracts (here you'll see every single one is touched but my PR because of the optimizations)
  • Fix gas usage expectation in one integration test for erc20, the gas consumed is reduces, probably because of the enabled optimization

Closes #629.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the main branch

@Pitasi Pitasi force-pushed the staking-return-full-description branch from 9420f0a to c535be9 Compare September 25, 2025 09:05
@vladjdk
Copy link
Member

vladjdk commented Oct 7, 2025

Approved - really dislike the fact that the .jsons are in the codebase and not in .gitignore despite the fact that I myself removed them. Will probably add them back. Overall, though, thanks!

@vladjdk vladjdk added this pull request to the merge queue Oct 7, 2025
Merged via the queue into cosmos:main with commit 80851f5 Oct 7, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

staking: return full validators' description
2 participants