Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate code quality tooling from Codecov to Sonar Cloud #2436

Closed
5 tasks
mmulji-ic opened this issue Apr 24, 2023 · 1 comment · Fixed by #2598
Closed
5 tasks

Migrate code quality tooling from Codecov to Sonar Cloud #2436

mmulji-ic opened this issue Apr 24, 2023 · 1 comment · Fixed by #2598
Assignees
@mpoke
Labels
scope: build Changes, features and bugs related the build process. scope: testing Code review, testing, making sure the code is following the specification.

Comments

@mmulji-ic
Copy link
Contributor

Summary

CodeCov only provides code coverage, whereas Sonar Cloud provides code coverage as well security warnings and code smells.

Type

Build, Test, Test Automation Debt

Impact

The additional metrics/warnings provided SonarCloud, will allow the development team to improve the code quality.

In additional to improved metrics, tool stability is important. Builds intermittently fail while using CodeCov and tests have to manually rerun to collect the full coverage history. This has been an ongoing issue for quite some time.

Proposed Solution

Proposal is to remove support for Codecov and then add support for Sonar Cloud only.

For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
  • Is a spike necessary to map out how the issue should be approached?
@mmulji-ic mmulji-ic added scope: build Changes, features and bugs related the build process. scope: testing Code review, testing, making sure the code is following the specification. devops labels Apr 24, 2023
@github-project-automation github-project-automation bot moved this to 🩹 Triage in Cosmos Hub Apr 24, 2023
@mmulji-ic mmulji-ic mentioned this issue Apr 24, 2023
Closed
@mpoke mpoke moved this from 🩹 Triage to 📥 Todo in Cosmos Hub Apr 24, 2023
@faddat
Copy link
Contributor

faddat commented Apr 25, 2023

strongly support this, tho likely that #2431 should remain open.

@mpoke mpoke self-assigned this May 26, 2023
@mpoke mpoke moved this from 📥 Todo to 🏗 In progress in Cosmos Hub May 26, 2023
@mpoke mpoke mentioned this issue Jun 15, 2023
Merged
8 tasks
@mpoke mpoke moved this from 🏗 In progress to 👀 In review in Cosmos Hub Jun 15, 2023
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Cosmos Hub Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpoke mpoke

Labels
scope: build Changes, features and bugs related the build process. scope: testing Code review, testing, making sure the code is following the specification.
Projects
Cosmos Hub
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: migrate code quality tooling from Codecov to Sonar Cloud cosmos/gaia
3 participants
@faddat @mpoke @mmulji-ic