-
Notifications
You must be signed in to change notification settings - Fork 692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use master branch of cosmos/ledger-cosmos-go #1801
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1801 +/- ##
=======================================
Coverage 43.19% 43.19%
=======================================
Files 15 15
Lines 1338 1338
=======================================
Hits 578 578
Misses 740 740
Partials 20 20 |
Thanks @faddat . We need to confirm whether there are API breaking changes that would impact users of gaia to ensure they're included in communications. Have you investigated what are the breaking changes between the updates you've included? |
Hi @faddat @okwme Could you provide some more info about these "strange things" you describe? Or it is related only to go.mod issues and a release would clear up the problem? |
I have just created this issue cosmos/ledger-cosmos-go#30 to track the repo reorganization that will take place soon |
@@ -256,6 +255,7 @@ require ( | |||
github.com/yagipy/maintidx v1.0.0 // indirect | |||
github.com/yeya24/promlinter v0.2.0 // indirect | |||
github.com/zondax/hid v0.9.1-0.20220302062450-5552068d2266 // indirect | |||
github.com/zondax/ledger-go v0.12.2 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The zondax/ledger-go
seems not well maintained. I think we should avoid importing this package into Gaia
thanks for the link to track progress @jleni ! |
While working on Akash today I noticed that there were some very
strange things going on with our ledger imports. The tl;dr is:
cosmos/ledger-go-cosmos
Here's a PR that gets Gaia on the right track, reflecting those changes.