fix: fix query archival states before the upgrade #2390
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catShaark
requested review from
alexanderbez,
zmanian,
yaruwangway,
crodriguezvega,
jackzampolin,
mmulji-ic,
glnro,
jtremback,
mpoke,
sainoe,
MSalopek and
shaspitz
as code owners
alexanderbez
reviewed
Apr 9, 2023
|
@alexanderbez, sorry, I'll convert this to a draft PR |
|
@alexanderbez so, I guess you mean use sdk 47? eg: 45 has been eol'd and Khanh's pr to that has been closed because it is eol'd, and folks do want to make queries to older gaia. |
5 tasks
|
@catShaark thanks for the contribution. Closing this PR though based on the following comment #2390 (review) |
|
and how shall users get their queries on? These changes were rejected on the 45 series sdk because it's been EOL'd, so there's a need to use a fork @alexanderbez -- I agree with you we shouldn't be on a fork here.... |
@faddat please see #2313 (comment) |
|
The hub is already on a fork of the SDK |
1 similar comment
|
The hub is already on a fork of the SDK |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2313
I use the sdk with modified
CacheMultiStoreWithVersionto support querying archival states before the upgrade