Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fee-Abstraction to Hub #3141

Closed
wants to merge 16 commits into from
Closed

Add Fee-Abstraction to Hub #3141

wants to merge 16 commits into from

Conversation

hoank101
Copy link

@hoank101 hoank101 commented Jun 7, 2024 •
edited
Loading

Add Fee-abstraction module to the Hub
Follow by Proposal 810

This PR will:

  • Add Feeabs module
  • Add DenomResolverImpl is Gaia's implementation of x/feemarket's DenomResolver

Old PR #2702

@hoank101 hoank101 marked this pull request as draft June 7, 2024 02:05
@mpoke
Copy link
Contributor

mpoke commented Jun 7, 2024

@hoank101 Please note that the globalfee module will be removed once we add the feemarket module from Skip. We plan to release this in Gaia v18. For more details, see the PR that is in review #3028.

@hoank101
Merge branch 'main' of https://github.com/cosmos/gaia into feat/feeabs
7c7a04c 
# Conflicts:
#	ante/ante.go
#	app/app.go
#	app/keepers/keepers.go
#	app/keepers/keys.go
#	app/modules.go
#	go.mod
#	x/globalfee/ante/antetest/fee_test_setup.go
#	x/globalfee/ante/fee.go
@hoank101
merge from main
a1cf01f
@hoank101
Merge branch 'main' of https://github.com/cosmos/gaia into feat/feeabs
3c5fb99 
# Conflicts:
#	ante/ante.go
@hoank101
fix lint
89a72a5
@hoank101 hoank101 marked this pull request as ready for review June 24, 2024 04:08
@hoank101
Copy link
Author

hi @mpoke can you review PR?

@hoank101
Copy link
Author

all test pass

@MSalopek
Copy link
Contributor

MSalopek commented Jul 15, 2024 •
edited
Loading

Would you mind explaining how you tested this feature? I don't see any additions to the integration or e2e tests.

The tests are passing because the feature added in this PR is is never triggered or it is not confirmed that it is getting triggered correctly.

@hoank101
Copy link
Author

Would you mind explaining how you tested this feature? I don't see any additions to the integration or e2e tests.

The tests are passing because the feature added in this PR is is never triggered or it is not confirmed that it is getting triggered correctly.

Thank you for your feedback. I will add more tests for feeabs. Currently, it passes the original Gaia test

@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Aug 30, 2024
@github-actions github-actions bot closed this Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmanian zmanian Awaiting requested review from zmanian zmanian is a code owner

@crodriguezvega crodriguezvega Awaiting requested review from crodriguezvega

@jackzampolin jackzampolin Awaiting requested review from jackzampolin jackzampolin is a code owner

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoank101 @mpoke @MSalopek