Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.8 RC1 #350

Merged
merged 2 commits into from
Apr 9, 2020
Merged

v2.0.8 RC1 #350

merged 2 commits into from
Apr 9, 2020

Conversation

alexanderbez
Copy link
Contributor

@alexanderbez alexanderbez commented Apr 9, 2020


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@alexanderbez alexanderbez marked this pull request as ready for review April 9, 2020 14:18
@alexanderbez alexanderbez added R4R and removed WIP labels Apr 9, 2020
@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #350 into rc1/v2.0.8 will decrease coverage by 0.43%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##           rc1/v2.0.8     #350      +/-   ##
==============================================
- Coverage       68.18%   67.74%   -0.44%     
==============================================
  Files               3        3              
  Lines             462      462              
==============================================
- Hits              315      313       -2     
- Misses            116      118       +2     
  Partials           31       31              

@alexanderbez alexanderbez merged commit e6f3eff into rc1/v2.0.8 Apr 9, 2020
@alexanderbez alexanderbez deleted the rc0/v2.0.8 branch April 9, 2020 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants