Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Gaia to latest SDK master #94

Merged
merged 4 commits into from
Aug 9, 2019

Conversation

fedekunze
Copy link
Collaborator

Updated to SDK commit: e4c8bd72b

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry: clog add [section] [stanza] [message]

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-io
Copy link

Codecov Report

Merging #94 into master will decrease coverage by 0.43%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master      #94      +/-   ##
==========================================
- Coverage   67.74%   67.31%   -0.44%     
==========================================
  Files           3        3              
  Lines         462      462              
==========================================
- Hits          313      311       -2     
- Misses        118      120       +2     
  Partials       31       31

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@alexanderbez alexanderbez merged commit 9c82ff2 into master Aug 9, 2019
@alexanderbez alexanderbez deleted the fedekunze/update-to-sdk-master branch August 9, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants