Bump Cosmos SDK and ibc-go #942

alexanderbez · 2021-08-16T15:20:04Z

Add x/feegrant and x/authz modules
Bump SDK version to v0.44.0
Bump ibc-go version to v1.1.0

TODO:

Update module path to v6
Verify the upgrade name: https://github.com/cosmos/gaia/pull/942/files#diff-0f1d2976054440336a576d47a44a37b80cdf6701dd9113012bce0e3c425819b7R546
Verify the new IBC params: https://github.com/cosmos/gaia/pull/942/files#diff-0f1d2976054440336a576d47a44a37b80cdf6701dd9113012bce0e3c425819b7R549
Change github.com/tendermint/liquidity v1.2.6-0.20210513094606-6cd272e3814d to the upcoming release version.
change dependency ibc-go from v1.0.0 to v1.1.0

For contributor use:

Targeted PR against correct branch (see CONTRIBUTING.md)
Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
Code follows the module structure standards.
Wrote unit and integration tests
Updated relevant documentation (docs/) or specification (x/<module>/spec/)
Added relevant godoc comments.
Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
Re-reviewed Files changed in the Github PR explorer

For admin use:

Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
Reviewers assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

cmd/gaiad/cmd/root.go

codecov · 2021-08-16T16:10:39Z

Codecov Report

Merging #942 (2fc911b) into main (fba9302) will decrease coverage by 1.56%.
The diff coverage is 1.96%.

@@            Coverage Diff             @@
##             main     #942      +/-   ##
==========================================
- Coverage   12.00%   10.44%   -1.57%     
==========================================
  Files          10       11       +1     
  Lines         933     1082     +149     
==========================================
+ Hits          112      113       +1     
- Misses        816      964     +148     
  Partials        5        5

cmd/gaiad/cmd/root.go

go.mod

okwme · 2021-08-25T16:01:16Z

https://github.com/cosmos/ibc-go/releases/tag/v1.0.1

colin-axner

first pass. The IBC changes looked good to me

app/pubkey_replacement.go

app/app.go

dongsam · 2021-08-31T03:02:00Z

Hi, Liquidity version v1.3.0 based on sdk v0.43.0 has been released,
and a separate PR #956 is ready to replace liquidity version to v1.3.0 for branch start-upgrade of this PR #942

Since the Cosmos-sdk version of this PR was updated based on v0.44.0, the liquidity was also bumped to v1.4.0 release based on sdk v0.44.0 on #956 PR
As was the latest version with Gaia, import to gravity-devs/liquidity, not to tendermint/liquidity.

app/ante_handler.go

app/app.go

AdityaSripal

Antehandler changes look good!

app/ante_handler.go

app/app.go

app/pubkey_replacement.go

app/app.go

app/ante_handler.go

amaury1093

authz and feegrant integration lgtm 👍

app/pubkey_replacement.go

app/app.go

alexanderbez · 2021-09-15T15:42:45Z

I think we can merge this once CI passes. If there are future versions of the SDK and/or ibc-go that we want to use, we can simply create PRs to bump go.mod in a future PR.

amaury1093

lgtm!

app/app.go

* gaia upgrade prepare * app updates * app updates * Update cmd/gaiad/cmd/root.go * Update cmd/gaiad/cmd/root.go * app updates * app updates * app updates * gaia v5 to v6 * remove redundancy, change "umeeApp" to "gaiaApp" * change upgrade name from "gaia-v6.0.0" to "vega" * readme for local test * add module versions * add liquidity * add authz and fee grant * add authz and grantfee * remove ibc from storeUpgrade * change upgrade readme * upgrade readme modify * use a created validator * change validator * Bump liquidity module to v1.3.0 based sdk v0.43.0 * docs: update changelog for liquidity * build: bump liquidity version to v1.4.0 * docs: update CHANGELOG.md * docs: lint CHANGELOG.md Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: yaruwang <yaruwang.materials@gmail.com> Co-authored-by: Aleksandr Bezobchuk <aleks.bezobchuk@gmail.com> Co-authored-by: Aleksandr Bezobchuk <alexanderbez@users.noreply.github.com> Co-authored-by: billy rennekamp <billy.rennekamp@gmail.com> Co-authored-by: kogisin <jaybkim2@gmail.com>

alexanderbez commented Aug 16, 2021

View reviewed changes

cmd/gaiad/cmd/root.go Outdated Show resolved Hide resolved

cmd/gaiad/cmd/root.go Outdated Show resolved Hide resolved

cmd/gaiad/cmd/root.go Outdated Show resolved Hide resolved

cmd/gaiad/cmd/root.go Outdated Show resolved Hide resolved

cmd/gaiad/cmd/root.go Outdated Show resolved Hide resolved

okwme reviewed Aug 17, 2021

View reviewed changes

cmd/gaiad/cmd/root.go Outdated Show resolved Hide resolved

okwme reviewed Aug 17, 2021

View reviewed changes

go.mod Outdated Show resolved Hide resolved

yaruwangway requested review from AdityaSripal and colin-axner August 17, 2021 15:14

dongsam mentioned this pull request Aug 19, 2021

V1: Porting to based sdk v0.43.0 and v0.44.0 for vega upgrade tendermint/liquidity#432

Closed

27 tasks

colin-axner reviewed Aug 26, 2021

View reviewed changes

app/pubkey_replacement.go Outdated Show resolved Hide resolved

app/app.go Show resolved Hide resolved

app/app.go Outdated Show resolved Hide resolved

app/app.go Show resolved Hide resolved

app/app.go Show resolved Hide resolved

dongsam mentioned this pull request Aug 27, 2021

Bump liquidity module v1.4.0 based sdk v0.44.0 #956

Merged

17 tasks

colin-axner mentioned this pull request Aug 30, 2021

gm parse errors with v0.43 gaia build informalsystems/hermes#1312

Closed

5 tasks

yaruwangway force-pushed the start-upgrade branch from 6df0921 to 487cdf7 Compare September 3, 2021 14:02

yaruwangway requested a review from crodriguezvega September 9, 2021 16:54

colin-axner reviewed Sep 10, 2021

View reviewed changes

app/ante_handler.go Outdated Show resolved Hide resolved

alexanderbez commented Sep 10, 2021

View reviewed changes

app/ante_handler.go Show resolved Hide resolved

alexanderbez commented Sep 10, 2021

View reviewed changes

app/app.go Outdated Show resolved Hide resolved

alexanderbez commented Sep 10, 2021

View reviewed changes

app/app.go Outdated Show resolved Hide resolved

AdityaSripal reviewed Sep 14, 2021

View reviewed changes

app/ante_handler.go Show resolved Hide resolved

app/ante_handler.go Outdated Show resolved Hide resolved

yaruwangway reviewed Sep 15, 2021

View reviewed changes

amaury1093 reviewed Sep 15, 2021

View reviewed changes

app/pubkey_replacement.go Outdated Show resolved Hide resolved

app/app.go Show resolved Hide resolved

alexanderbez marked this pull request as ready for review September 15, 2021 15:37

alexanderbez requested review from alessio, jgimeno and zmanian as code owners September 15, 2021 15:37

amaury1093 approved these changes Sep 15, 2021

View reviewed changes

app/app.go Show resolved Hide resolved

yaruwangway and others added 3 commits September 16, 2021 14:15

gaia upgrade prepare

7e6ce2d

app updates

ef90d55

app updates

7ab19da

yaruwangway and others added 23 commits September 16, 2021 14:25

upgrade readme modify

c25ba53

use a created validator

b229063

change validator

3931e26

readme: upgrade by cosmosvisor

37b6184

rebase update go.mod

15647a2

sdk v0.44.0, ibc v1.1.0, liquidity v1.4.0

c0e1719

move local test readme to vega-test repo.

dbaf19f

tendermint 0.34.12 to 0.34.13

04e5c08

change back tendermint version to v0.34.12

418ea4f

app: update AnteHandler

9a76491

lint++

23fc62f

lint++

91d7d74

update VM versions

26a5263

lint++

de2f4c9

tendermint version change to 0.34.13

36ecd1e

lint++

f2a9208

auth migration 1 -> 2

72039f5

clean todo from vega start-upgrade

7d57611

chore: update changelog

7729574

bump ibc to v1.2.0

540d21b

rebase change

e72714b

rebase again

8758329

yaruwangway force-pushed the start-upgrade branch from f42f502 to 8758329 Compare September 16, 2021 13:42

yaruwangway added 2 commits September 16, 2021 15:53

auth module version change back to 1

5a7e2e8

change log

2fc911b

okwme approved these changes Sep 17, 2021

View reviewed changes

okwme merged commit 2947cb5 into main Sep 17, 2021

okwme deleted the start-upgrade branch September 17, 2021 07:19

YasunoriMATSUOKA mentioned this pull request Jan 4, 2022

bump Cosmos SDK from v0.42.9 to v0.44.5 UnUniFi/chain#136

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump Cosmos SDK and ibc-go #942

Bump Cosmos SDK and ibc-go #942

alexanderbez commented Aug 16, 2021 •

edited

Loading

codecov bot commented Aug 16, 2021 •

edited

Loading

okwme commented Aug 25, 2021

colin-axner left a comment

dongsam commented Aug 31, 2021 •

edited

Loading

AdityaSripal left a comment

amaury1093 left a comment

alexanderbez commented Sep 15, 2021

amaury1093 left a comment

Bump Cosmos SDK and ibc-go #942

Bump Cosmos SDK and ibc-go #942

Conversation

alexanderbez commented Aug 16, 2021 • edited Loading

codecov bot commented Aug 16, 2021 • edited Loading

Codecov Report

okwme commented Aug 25, 2021

colin-axner left a comment

Choose a reason for hiding this comment

dongsam commented Aug 31, 2021 • edited Loading

AdityaSripal left a comment

Choose a reason for hiding this comment

amaury1093 left a comment

Choose a reason for hiding this comment

alexanderbez commented Sep 15, 2021

amaury1093 left a comment

Choose a reason for hiding this comment

alexanderbez commented Aug 16, 2021 •

edited

Loading

codecov bot commented Aug 16, 2021 •

edited

Loading

dongsam commented Aug 31, 2021 •

edited

Loading