fix(nodedb): prevent deadlock by releasing DeleteVersionsFrom mutex on error #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tac0turtle
approved these changes
Oct 16, 2023
…n error Noticed during an audit that there can be a deadlock resulting from an unreleased mutex if there happens to be a newer version with one or more concurrent readers. Fixes cosmos#842
odeke-em
force-pushed
the
nodedb-prevent-deadlock-from-unreleased-mutex-on-DeleteVersionsFrom-error
branch
from
13a7f47
to
a55ac33
Compare
odeke-em
changed the title
|
@Mergifyio backport release/v1.x.x |
✅ Backports have been created
|
odeke-em
deleted the
nodedb-prevent-deadlock-from-unreleased-mutex-on-DeleteVersionsFrom-error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed during an audit that there can be a deadlock resulting from an unreleased mutex if there happens to be a newer version with one or more concurrent readers.
Fixes #842