Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R4R: ICS 1: Interchain Standard #17

Merged
merged 19 commits into from
Mar 7, 2019
Merged

R4R: ICS 1: Interchain Standard #17

merged 19 commits into from
Mar 7, 2019

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Feb 12, 2019

Ref #16

@cwgoes cwgoes added meta Issues or proposals about the ICS process. wip Issues or pull requests which are in progress. labels Feb 12, 2019
jackzampolin
jackzampolin reviewed Feb 12, 2019
View reviewed changes
spec/ics-1-ics-standard.md Outdated
created: 2019-02-12
---

## What is an ICS?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@jackzampolin
Copy link
Member

@cwgoes Is this ready to go?

@cwgoes
Copy link
Contributor Author

cwgoes commented Feb 25, 2019 •
edited
Loading

@cwgoes Is this ready to go?

No, not yet; distracted by cosmos/cosmos-sdk#3723

Let me add more details on suggested formatting & contents. On it!

@cwgoes cwgoes changed the title WIP: Start on ICS 1 Start on ICS 1 Mar 4, 2019
@cwgoes cwgoes changed the title Start on ICS 1 R4R: Start on ICS 1 Mar 4, 2019
@cwgoes cwgoes added ready-for-review Pull requests which are ready for review. and removed wip Issues or pull requests which are in progress. labels Mar 4, 2019
@cwgoes cwgoes requested a review from jackzampolin March 4, 2019 15:43
@cwgoes cwgoes changed the title R4R: Start on ICS 1 R4R: ICS 1: Interchain Standard Mar 4, 2019
@cwgoes cwgoes requested a review from mossid March 4, 2019 15:49
@cwgoes cwgoes mentioned this pull request Mar 4, 2019
Closed
@cwgoes cwgoes requested a review from alexanderbez March 4, 2019 15:52
jackzampolin
jackzampolin reviewed Mar 4, 2019
View reviewed changes
spec/ics-1-ics-standard/README.md

### Language

ICS specifications should be written in Simple English, avoiding obscure terminology and unnecessary jargon. For excellent examples of Simple English, please see the [Simple English Wikipedia](https://simple.wikipedia.org/wiki/Main_Page).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ Love this ❤️

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

jackzampolin
jackzampolin approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@jackzampolin jackzampolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 🌃 🔥 Looks great @cwgoes

alexanderbez
alexanderbez approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Left a few minor comments.

spec/ics-1-ics-standard/README.md Show resolved Hide resolved
spec/ics-1-ics-standard/README.md Outdated Show resolved Hide resolved
spec/ics-1-ics-standard/README.md

### Language

ICS specifications should be written in Simple English, avoiding obscure terminology and unnecessary jargon. For excellent examples of Simple English, please see the [Simple English Wikipedia](https://simple.wikipedia.org/wiki/Main_Page).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

alexanderbez
alexanderbez approved these changes Mar 4, 2019
View reviewed changes
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@cwgoes cwgoes mentioned this pull request Mar 5, 2019
Closed
mossid
mossid reviewed Mar 5, 2019
View reviewed changes
Copy link

@mossid mossid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👍

spec/ics-1-ics-standard/README.md Outdated Show resolved Hide resolved
spec/ics-1-ics-standard/README.md Outdated Show resolved Hide resolved
@cwgoes
Copy link
Contributor Author

cwgoes commented Mar 7, 2019

Merging as a draft - more comments welcome anytime, probably best on the issue.

@cwgoes cwgoes merged commit 0c97953 into master Mar 7, 2019
@cwgoes cwgoes deleted the cwgoes/ics-1-ics-standard branch March 7, 2019 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValarDragon ValarDragon ValarDragon left review comments

@mossid mossid mossid left review comments

@alexanderbez alexanderbez alexanderbez approved these changes

@jackzampolin jackzampolin jackzampolin approved these changes

@rigelrozanski rigelrozanski Awaiting requested review from rigelrozanski

@jaekwon jaekwon Awaiting requested review from jaekwon

@zmanian zmanian Awaiting requested review from zmanian

Assignees
No one assigned
Labels
meta Issues or proposals about the ICS process. ready-for-review Pull requests which are ready for review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cwgoes @jackzampolin @alexanderbez @ValarDragon @mossid