You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Improve Korean line-breaking readability with word-break: keep-all on .content#2781
In Korean, a single word (eojeol) can be split at an arbitrary character at
the end of a line under the default line-breaking behavior.
This hurts readability for Korean readers, as words get broken in the middle rather than
wrapping as a whole.
Proposal
Add word-break: keep-all; to the .content selector in _sass/base/_base.scss.
Per the CSS spec, keep-all does not change wrapping for non-CJK text
(e.g. English), so existing rendering for English posts is unaffected.
.content already declares overflow-wrap: break-word;, so long
unbreakable tokens (e.g. URLs) still wrap and there is no overflow risk.
Scope / Motivation
My primary motivation is Korean readability, so I'm focusing this request on Korean.
That said, keep-all applies to CJK line-breaking in general,
so Chinese and Japanese readers would likely benefit from the same behavior as
well.
This is a readability/accessibility fix, not a typography style preference.
It's a one-line, low-risk change that helps a meaningful portion of Chirpy's user base.
I'm happy to open a PR if this direction is acceptable.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Problem
In Korean, a single word (eojeol) can be split at an arbitrary character at
the end of a line under the default line-breaking behavior.
This hurts readability for Korean readers, as words get broken in the middle rather than
wrapping as a whole.
Proposal
Add
word-break: keep-all;to the.contentselector in_sass/base/_base.scss.keep-alldoes not change wrapping for non-CJK text(e.g. English), so existing rendering for English posts is unaffected.
.contentalready declaresoverflow-wrap: break-word;, so longunbreakable tokens (e.g. URLs) still wrap and there is no overflow risk.
Scope / Motivation
My primary motivation is Korean readability, so I'm focusing this request on Korean.
That said,
keep-allapplies to CJK line-breaking in general,so Chinese and Japanese readers would likely benefit from the same behavior as
well.
This is a readability/accessibility fix, not a typography style preference.
It's a one-line, low-risk change that helps a meaningful portion of Chirpy's user base.
I'm happy to open a PR if this direction is acceptable.
All reactions