Use constants for blip replication strings, internal doc properties #3799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switch to using constants for blip message names and message properties, as well as the internal doc properties _id, _rev and _deleted. Includes some refactoring of blip_sync_messages to better support read/write of message properties, and a new test for the SetCheckpoint message.
JFlath
reviewed
Oct 14, 2018
JFlath
reviewed
Oct 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using constants for blip message names and message properties, as well as the internal doc properties _id, _rev and _deleted.
Includes some refactoring of blip_sync_messages to better support read/write of message properties, and a new test for the SetCheckpoint message.
Fixes #3771