chore: E2E test migration #226
Conversation
## Description Base test contract for forked tests in e2e tests ## Test Plan CI ## Related Issues
## Description This PR replaces llamarpc with merkle.io for the RPC as there are higher RPS. ## Test Plan 1. Ensure CI/CD remains green for fork tests. ## Related Issues N/A
## Description In order to make use of cache, and to convey to testers / developers what the assumptions of fork tests are, the fork block number is established as a constant within the `Helper.sol`. ## Test Plan 1. Verify that CI/CD passes. ## Related Issues N/A
## Description This PR sets the `FORK_URL` environment variable to a mainnet archive node with sufficient RPS / capacity to facilitate the fork tests. ## Test Plan 1. Verify CI/CD green. ## Related Issues N/A
## Description Migrate the smartOrder e2e test to foundry. Depends on #215. ## Test Plan CI ## Related Issues Issue doesn't exist
## Description This PR addresses the environment setup that was used for fork tests. Now, the `FORK_URL` is set by a secret, and the `FORK_BLOCK_NUMBER` is hard coded within the `e2e` Helper as a constant so that assumptions are visible for auditors / developers. ## Test Plan 1. Confirm CI/CD green ## Related Issues N/A
## Description This PR removes extraneous TypeScript that has been left over as a result of the E2E tests. ## Test Plan 1. Confirm CI/CD green. ## Related Issues #130
|
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is a critical CVE?Contains a Critical Common Vulnerability and Exposure (CVE). Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
2 participants
Description
This PR is to close out the milestone of migrating tests to foundry. As all E2E tests have been migrated into the
e2e-migrationbranch for staging purposes, this PR then merges (through use of rebase / fast-forward) these tests to themainbranch.Test Plan
Related Issues
Fixes #130