Skip to content

Log fatal php errors to stream log #10366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 15, 2022
Merged

Log fatal php errors to stream log #10366

merged 4 commits into from
Jan 15, 2022

Conversation

timkelty
Copy link
Contributor

@timkelty timkelty commented Jan 14, 2022 •
edited
Loading

This sends fatal PHP errors to php://stderr when the app has opted in to CRAFT_STREAM_LOG, which is most likely what you want if you've set that.

@timkelty timkelty changed the title Fatal php stream log Log fatal php errors to stream log Jan 14, 2022
@timkelty
Copy link
Contributor Author

@mattstein Probably worth a mention on:

angrybrad
angrybrad approved these changes Jan 14, 2022
View reviewed changes
Copy link
Member

@angrybrad angrybrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@angrybrad
Copy link
Member

@timkelty we should add a changelog item for it probably as a bug fix

jasonmccallister
jasonmccallister approved these changes Jan 15, 2022
View reviewed changes
Copy link
Contributor

@jasonmccallister jasonmccallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯!!

@brandonkelly brandonkelly merged commit 294d95a into develop Jan 15, 2022
@brandonkelly brandonkelly deleted the feature/fatal-php-stream-log branch January 15, 2022 20:13
mattstein pushed a commit to craftcms/docs that referenced this pull request Jan 17, 2022
Note PHP fatal error → stderr behavior.
ac69d92 
craftcms/cms#10366
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonkelly brandonkelly brandonkelly approved these changes

@angrybrad angrybrad angrybrad approved these changes

+1 more reviewer

@jasonmccallister jasonmccallister jasonmccallister approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@timkelty @angrybrad @brandonkelly @jasonmccallister