-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloud-docs rst->md conversion #55
Conversation
remove old glossary.rst
fix link
link again
Went through all the changes pretty rigorously multiple times, but it's a big change so would appreciate a review from anyone interested. Thank you in advance. The main concern is broken links/references, although checks should catch those. Technically everything should work, quite sure of that. |
|
||
:::: | ||
|
||
## Cluster Management |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
## Cluster Management | |
::: | |
## Cluster Management | |
::: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrapping them doesn't show them in the toc
Co-authored-by: Georg Traar <proddata@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi. That's a huge amount of work which went into this patch, thank you very much! 💯
Currently, I don't have the capacity to review it completely, roughly about 4,000 lines being changed, so please either wait for another cycle (one day or two), or just merge when you need it, and when there are no other objections. I've just added a few suggestions while quickly navigating into the patch, nothing serious.
````{note} | ||
Complete documentation on clusters in Croud, including all the | ||
deployment arguments, can be found | ||
[here](https://crate.io/docs/cloud/cli/en/latest/commands/clusters.html). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it also works like this to refer to a doc
label? I didn't try, yet. If it works, it would also be a good candidate to expand the authoring guide about referencing correspondingly.
[here](https://crate.io/docs/cloud/cli/en/latest/commands/clusters.html). | |
[here](inv:croud#commands/clusters). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also added a note about this where to improve the authoring guidelines.
Co-authored-by: Andreas Motl <andreas.motl@crate.io>
Hi @amotl. Do you still need couple more days to look this over, or are you happy with it? |
Hi Matej. I can't find the cycles, unfortunately. I think it will be good to go, please go ahead. Thanks again! |
What's Inside
Significant changes.
Preview
https://crate-cloud--55.org.readthedocs.build/en/55/
Highlights
howtos - rst->md
tutorials/edge
reference - rst->md
tutorials/deploy/croud.md - rst->md
Checklist